Removes newline at end of package.json and bower.json

[bevry]

Removes newline at end of package.json and bower.json

[balupton]

Why is it needed for git and vim? Never had an issue before with git.

[hvoecking]

It's actually a unix thing I just mentioned these tools because that's where for me the newlines are relevant:

• If you open a file in vim and save it (no matter if you modified it or not), it automatically appends a newline (therefore you always have a diff at the end of the file, even if you did not actually change something in the file).
• Git (and github) complain if you remove the newline at the end of the file in a commit, see eg. this commit.

[mightyiam]

👍 Vim makes the same newline for me, as well.

This is like EditorConfig's insert_final_newline = true.

It shouldn't remove a newline, if one exists. It shouldn't add one, as well, FWIW.

[balupton]

It shouldn't remove a newline, if one exists. It shouldn't add one, as well, FWIW.

Good idea. Will see what we can do. @pflannery do you want to grab this one?

[pflannery]

@balupton Im guessing this is just a matter of adding a new line during "Save package files" like data = JSON.stringify(@dataForPackagesEnhanced[name], null, ' ') + '\n' ??

(Shame we cant reference line number to projectz.litcoffee files)

[pflannery]

It shouldn't remove a newline, if one exists. It shouldn't add one, as well, FWIW.

I've determined that both npm and bower (init, --save and --save-dev) append an LF to the file so I don't think its worth the extra effort in trying to detect if an LF wasn't present originally. Instead my PR just does what npm and bower do and that's append an LF to the end of the JSON

[mightyiam]

Instead my PR just does what npm and bower do and that's append an LF to the end of the JSON

Great

[mightyiam]

Thank you.