Giter Site home page Giter Site logo

Comments (2)

intrepidws avatar intrepidws commented on May 22, 2024

After looking around a bit more, it seems that the conventions surrounding the Role name field are pretty inconsistent. When creating a new role, name is made lowercase:

Forms\Components\TextInput::make('name')
    ->label(__('filament-shield::filament-shield.field.name'))
    ->required()
    ->maxLength(255)
    ->afterStateUpdated(fn (Closure $set, $state): string => $set('name', Str::lower($state))),

And when displayed in the table, it's shown as headline case:

Tables\Columns\BadgeColumn::make('name')
    ->label(__('filament-shield::filament-shield.column.name'))
    ->formatStateUsing(fn ($state): string => Str::headline($state))
    ->colors(['primary'])
    ->searchable(),

I could be missing it entirely, but it doesn't seem like there's a reason to enforce ANY case at all with the name of a role?

Again, I'm happy to PR the changes but would be interested in hearing how you'd prefer to handle this situation before I do.

from filament-shield.

bezhanSalleh avatar bezhanSalleh commented on May 22, 2024

these have been there from the start, didn't even notice them until v2.
and has been refactored in #69 .. which will be available in the next release 2.0.5 or 2.0.6 😇

from filament-shield.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.