add support for binary key and value

[GoogleCodeExporter]

add support for binary key and value

[GoogleCodeExporter]

updated for credis_delv

int credis_delv(REDIS rhnd, const char *key, size_t key_len);

Original comment by [email protected] on 9 May 2010 at 6:30

Attachments:

• credis.c
• credis.h

[GoogleCodeExporter]

Thanks for the patch. I have received at least 3 different patches on how to 
add binary 
support. I'm trying to decided for the approach that is most appealing.

Original comment by [email protected] on 19 May 2010 at 8:10

[GoogleCodeExporter]

hi. added a few alternatives to binary branch: 
http://code.google.com/p/credis/source/diff?
spec=svn32&r=32&format=side&path=/branches/binary-
support/credis.c&old_path=/branches/binary-support/credis.c&old=26

what do you think?

I'm not aware of an "official" Redis document that specifies which commands 
that 
support binary data... do you know? Otherwise it is time for me to dig into the 
Redis 
code.

Original comment by [email protected] on 20 May 2010 at 11:49

• Changed state: Started

[GoogleCodeExporter]

From my point, I will not care the time of memcpy since the bottleneck will 
never at 
the memory bandwidth. Even so, I think we could support the writev at 
cr_senddata 
level, because cr_sendvandreceive is just a protocol level function.

redis seems split the query command base on ' ', it means all the commands 
could 
support the binary key

http://github.com/antirez/redis/blob/master/redis.c#L2595

for the binary data, I think you could check it's cmdTable

http://github.com/antirez/redis/blob/master/redis.c#L744

Original comment by [email protected] on 21 May 2010 at 3:12

[GoogleCodeExporter]

When would you add binary support? I need it!

Original comment by [email protected] on 21 Jul 2010 at 8:05