Error When Opening Links

[bhspitmonkey]

Error When Opening Links

[BHSPitMonkey]

Hi,

Few things:

• There's actually a deb package on the Releases page now, so you can avoid needing to build it yourself if you prefer
• The URL in your example looks invalid (I see only one slash after https), could that be the cause?
• Can you make sure the xdg-open command works on your machine in a terminal?

[ryan-clancy]

xdg-open works fine in the terminal, and trailing slashes on URLs are valid as well (test using xdg-open or any web browser).

I haven't tested the deb package that you've provided, for now I'm just running it in a screen with "npm start".

[BHSPitMonkey]

I meant the slash after the protocol: "https:/" vs. "https://". Not sure if
that's a formatting bug or if that's actually the URL passed to xdg-open.
For what it's worth, I haven't had any problems with links in hipchat
conversations (using either launch method), so I might not have a solution
for you until I can reproduce.

On Sat, May 21, 2016, 11:37 Ryan Clancy [email protected] wrote:

xdg-open works fine in the terminal, and trailing slashes on URLs are
valid as well (test using xdg-open or any web browser).

I haven't tested the deb package that you've provided, for now I'm just
running it in a screen with "npm start".

—
You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#3 (comment)

[ryan-clancy]

Ahh, I see - that must just be a formatting bug, it shows up fine in HipChat (although xdg-open still seems to handle the single slash).

I'll close this issue as it can't seem to be reproduced and appears to be local to my environment.

[BHSPitMonkey]

I'm seeing this myself now; It seems to be an issue with the packaged version. I was testing before using the source / npm start. Will investigate.

[ryan-clancy]

The error appears to be gone, but now when I click a link nothing happens. Are you seeing this behavior as well?

[BHSPitMonkey]

@r-clancy - I finally got it figured out. In addition to necessitating the previous change, the open module also has a bug that causes it not to work when there are spaces in the install path (and this package currently installs to /opt/HipChat Electron/). I've just published a 1.0.1 release with updated packages. Thanks for the report and info!