Giter Site home page Giter Site logo

Comments (4)

kaczmarj avatar kaczmarj commented on June 15, 2024 2

@chrisfilo - i agree with @yarikoptic. dir should be valid for all epi, or it shouldn't be a tag at all.

it's confusing to have dir mean phase encoding direction for field map, and then acq potentially mean phase encoding direction for dwi, bold, etc. i am bids-ifying a study that uses AP and PA direction for dwi and bold, and it's inconsistent to specify the phase encoding direction with dir- for the field maps but acq- for dwi and bold, when they represent the same information.

from bids-specification.

chrisgorgo avatar chrisgorgo commented on June 15, 2024

I am a bit skeptical:

  • it makes the filenames potentially longer
  • creates two ways to describe the same thing (acq-PA and dir-PA)

I'm also not sure there would be such a big benefit from this change in terms of usability.

from bids-specification.

yarikoptic avatar yarikoptic commented on June 15, 2024

Length stays the same since len(acq) == len(dir), unless there is also actually something else to say about acq.
acq is too generic/non-specific, dir meaning is consistent with current use in fmap, and potentially would be used for the same purpose.
To me it is about clarity - again acq can't be interpreted pretty much, while dir could

from bids-specification.

chrisgorgo avatar chrisgorgo commented on June 15, 2024

Please make a pull request - we can see if anyone feels strongly against this.

from bids-specification.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.