Storing FK as strings without relationships

[bigfastcode]

Storing FK as strings without relationships

[phemmylintry]

@DisuToyin 👆🏽

[nseetim]

So I noticed in the models, that Foreign Key relationships are been stored as strings. Is there a reason why that is for e.g

bigfastapi/bigfastapi/models/bank_models.py

Line 19 in 2cb4735

id = Column(String(255), primary_key=True, index=True, default=uuid4().hex)

In my opinion, I think this will limit lookups So let's say we have an instance of bank models (bank_instance). I don't think I would be able to do a lookup on organizations, since it's basically stored as a string bank_instance.organization # this will return the id type(str)

My suggestion is why not create a relationship between the two tables organization = relationship("Organizations")

reference: https://docs.sqlalchemy.org/en/14/orm/basic_relationships.html#many-to-one

I noticed this on many other models, maybe there is a reason for this. Thanks

Nice observation
But i think you actually intended mentioning this line

bigfastapi/bigfastapi/models/bank_models.py

Line 20 in 2cb4735

organization_id = Column(String(255), ForeignKey("organizations.id"))

[phemmylintry]

So I noticed in the models, that Foreign Key relationships are been stored as strings. Is there a reason why that is for e.g

bigfastapi/bigfastapi/models/bank_models.py

Line 19 in 2cb4735

id = Column(String(255), primary_key=True, index=True, default=uuid4().hex)

In my opinion, I think this will limit lookups So let's say we have an instance of bank models (bank_instance). I don't think I would be able to do a lookup on organizations, since it's basically stored as a string bank_instance.organization # this will return the id type(str)
My suggestion is why not create a relationship between the two tables organization = relationship("Organizations")
reference: https://docs.sqlalchemy.org/en/14/orm/basic_relationships.html#many-to-one
I noticed this on many other models, maybe there is a reason for this. Thanks

Nice observation But i think you actually intended mentioning this line

bigfastapi/bigfastapi/models/bank_models.py

Line 20 in 2cb4735

organization_id = Column(String(255), ForeignKey("organizations.id"))

So I noticed in the models, that Foreign Key relationships are been stored as strings. Is there a reason why that is for e.g

bigfastapi/bigfastapi/models/bank_models.py

Line 19 in 2cb4735

id = Column(String(255), primary_key=True, index=True, default=uuid4().hex)

In my opinion, I think this will limit lookups So let's say we have an instance of bank models (bank_instance). I don't think I would be able to do a lookup on organizations, since it's basically stored as a string bank_instance.organization # this will return the id type(str)
My suggestion is why not create a relationship between the two tables organization = relationship("Organizations")
reference: https://docs.sqlalchemy.org/en/14/orm/basic_relationships.html#many-to-one
I noticed this on many other models, maybe there is a reason for this. Thanks

Nice observation But i think you actually intended mentioning this line

bigfastapi/bigfastapi/models/bank_models.py

Line 20 in 2cb4735

organization_id = Column(String(255), ForeignKey("organizations.id"))

Yea, that line. Thanks

[kofimokome]

Hello, we use uuid as unique identifer (id) for our tables. That explains why the foreign key is stored as string

[teniolafatunmbi]

So I noticed in the models, that Foreign Key relationships are been stored as strings. Is there a reason why that is for e.g

bigfastapi/bigfastapi/models/bank_models.py

Line 19 in 2cb4735

id = Column(String(255), primary_key=True, index=True, default=uuid4().hex)

In my opinion, I think this will limit lookups So let's say we have an instance of bank models (bank_instance). I don't think I would be able to do a lookup on organizations, since it's basically stored as a string bank_instance.organization # this will return the id type(str)

My suggestion is why not create a relationship between the two tables organization = relationship("Organizations")

reference: https://docs.sqlalchemy.org/en/14/orm/basic_relationships.html#many-to-one

I noticed this on many other models, maybe there is a reason for this. Thanks

Yes, a relationship would do but that would not be generic enough since users of BFA do not have the same need. The base scenario for users is using these models is that they would need the FK references, not the lookups.