Giter Site home page Giter Site logo

Comments (3)

bigyanpoudel avatar bigyanpoudel commented on June 7, 2024

Hello @anserwaseem Since the modal is configured outside the configuration of react router. So we need to configure the modal inside the configuration of the routes. So can you try including the modal configuration with in the top most element inside createBrowserRouter

const ModalRouteWrapper = () => {
  useEffect(() => {
    //Registering modal in the dom
    GlobalModal.setUpModal(globalModalRef)
  }, [])
  return (
    <>
      <Outlet />
      <ModalWrapper ref={(el) => (globalModalRef = el)} />
    </>
  )
}

const router =
      createBrowserRouter([
 {
    element: <ModalRouteWrapper />,
    children: [      {
          path: "/",
          element: <Entry entry={app.home} />,
          errorElement: <ErrorPage />,
          children: app.screens.map((screen) => {
            return {
              path: `${screen.name.toLowerCase()}`,
              element: <Screen key={screenId} screen={screen} />,
            };
          }),
        },]},
  
      ])

In this way, you will have browser router access within the modal

from react-global-modal.

anserwaseem avatar anserwaseem commented on June 7, 2024

Thank you @bigyanpoudel, i've updated code like this:
but nothing is working now, no error no working!

let globalModalRef: any = null;

export const App: React.FC<AppProps> = ({
  appId,
  application,
}) => {
  const resolvedApp = application ?? ApplicationLoader.load(appId);
  const app = Parser.parseApplication(resolvedApp);

  const router = useMemo(
    () =>
      createBrowserRouter([
        {
          element: <ModalRouteWrapper />,
          children: [
            {
              path: "/",
              element: <Entry entry={app.home} />,
              errorElement: <ErrorPage />,
              children: app.screens.map((screen) => {
                return {
                  path: `${screen.name.toLowerCase()}`,
                  element: <Screen key={screenId} screen={screen} />,
                };
              }),
            },
          ],
        },
      ]),
    [app],
  );
  return (
    <ApplicationContextProvider app={app}>
      <ThemeProvider>
        <RouterProvider router={router} />
        <ToastContainer />
      </ThemeProvider>
    </ApplicationContextProvider>
  );
};

const ModalRouteWrapper: React.FC = () => {
  useEffect(() => {
    //Registering modal in the dom
    GlobalModal.setUpModal(globalModalRef);
  }, []);
  return (
    <>
      <Outlet />
      <GlobalModalWrapper ref={(el) => (globalModalRef = el)} />
    </>
  );
};

Note: im using GlobalModalWrapper not the ModalWrapper that you used above

from react-global-modal.

anserwaseem avatar anserwaseem commented on June 7, 2024

i was missing setting up customModal property,

it's working fine now!

Thank you so much @bigyanpoudel 🥇

from react-global-modal.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.