Giter Site home page Giter Site logo

Comments (3)

billerickson avatar billerickson commented on August 15, 2024

You're totally correct. When I wrote that documentation I thought I had used get_option( 'posts_per_page' ) but it looks like I hardcoded it.

I'm hesitant to change it now because it will affect all existing users of the plugin. Someone might be expecting Display Posts to continue showing 10 posts per page even though they have it set to 99 in Settings > Reading.

I think it would be safer to update the documentation to say it shows 10 by default and explain how you can change it (posts_per_page parameter on the shortcode itself, or a filter to change the site-wide default)

from display-posts-shortcode.

pjohanneson avatar pjohanneson commented on August 15, 2024

Fair enough. Here's the code I used (I just put it in a mu-plugins plugin, but it can go anywhere):

<?php
/**
Plugin Name: Fix Display Posts shortcode ยต
Description: Use the site's 'posts_per_page' option in the shortcode's args.
*/

add_filter( 'display_posts_shortcode_args', function( $args ) {
    if ( ! is_array( $args ) ) {
        return $args;
    }
    $posts_per_page = get_option( 'posts_per_page', 0 );
    if ( ! empty( $posts_per_page ) ) {
        $posts_per_page = intval( $posts_per_page );
        $args['posts_per_page'] = $posts_per_page;
    }
    return $args;
} );

from display-posts-shortcode.

billerickson avatar billerickson commented on August 15, 2024

I've updated the tutorial on the Display Posts websites to more accurately describe the default, and provide examples of how to change it: https://displayposts.com/2019/01/07/limit-the-number-of-posts-shown/

from display-posts-shortcode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.