Giter Site home page Giter Site logo

Comments (2)

BinaryMuse avatar BinaryMuse commented on June 1, 2024

Can you please elaborate?

from fluxxor.

totty90 avatar totty90 commented on June 1, 2024

After having digged a little bit more:
You are doing this right (: Nice to see this (vs the pure Flux examples, which are singletons). As you can understand, I didn't read good enough your example and missed this part:

var stores = {
  CarouselStore: new CarouselStore({count: images.length}),
  ImageStore: new ImageStore({images: images})
};

var flux = new Fluxxor.Flux(stores, actions);`

Which made me thought that you were storing the stores somewhere into your Fluxxor lib at definition time. You can close this issue. I'm thinking of using your lib into my current projects (:

Sorry about the misunderstanding.

Previous comment (before noticing is not a singleton):
Almost everything in your architecture is a singleton.

For example in app you require StoreWatchMixin = Fluxxor.StoreWatchMixin; which then you init like this mixins: [FluxMixin, StoreWatchMixin("ImageStore", "CarouselStore")]. This means that your StoreWatchMixin is saving each store by it's name. You then var flux = this.getFlux(); and flux.store("ImageStore").

You create the store with var CarouselStore = Fluxxor.createStore({, but this for me would mean just a class definition, not a singleton as it is.

I don't know if you know what are singletons and if they are bad, but you can read here.

from fluxxor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.