Comments (2)
Can you please elaborate?
from fluxxor.
After having digged a little bit more:
You are doing this right (: Nice to see this (vs the pure Flux examples, which are singletons). As you can understand, I didn't read good enough your example and missed this part:
var stores = {
CarouselStore: new CarouselStore({count: images.length}),
ImageStore: new ImageStore({images: images})
};
var flux = new Fluxxor.Flux(stores, actions);`
Which made me thought that you were storing the stores somewhere into your Fluxxor lib at definition time. You can close this issue. I'm thinking of using your lib into my current projects (:
Sorry about the misunderstanding.
Previous comment (before noticing is not a singleton):
Almost everything in your architecture is a singleton.
For example in app you require StoreWatchMixin = Fluxxor.StoreWatchMixin;
which then you init like this mixins: [FluxMixin, StoreWatchMixin("ImageStore", "CarouselStore")]
. This means that your StoreWatchMixin
is saving each store by it's name. You then var flux = this.getFlux();
and flux.store("ImageStore")
.
You create the store with var CarouselStore = Fluxxor.createStore({
, but this for me would mean just a class definition, not a singleton as it is.
I don't know if you know what are singletons and if they are bad, but you can read here.
from fluxxor.
Related Issues (20)
- resetting stores HOT 2
- Question: asynchronous route transition HOT 1
- Inconsistent description of stores? HOT 4
- Fluxxor and React Router 1.x and ES6 HOT 7
- this.isMounted is not a function HOT 2
- Best practices for nested models HOT 1
- React warning after update to 1.7.2 HOT 1
- fluxxor with react router 1rc HOT 16
- Can one use Fluxxor with React Native? HOT 2
- Use instanceOf or shape in context types and add propTypes
- Wait until async request completes HOT 2
- Routing examples no longer work with latest version of React Router HOT 3
- Lost events with StoreWatchMixin during ComponentWillMount -> ComponentDidMount HOT 1
- Documentation for setting dispatch interceptor is out of date HOT 3
- In the Async Example not clear how to support add action which needed to call out to server HOT 1
- React-Router v4 and Fluxxor
- Current lodash dependency has a CVE
- Compatibility with React 16 HOT 2
- Typo in a link on the "What is Flux" page
- sdasdasdas
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluxxor.