Implementation of MSTDPET is wrong?

[bindsnet]

Implementation of MSTDPET is wrong?

[djsaunde]

Hi @godelicbach,

Thanks for the catch! I think this is the best way to handle this problem, by the way, since it makes it easy for me to understand the issue before rewriting any code.

The implementation does seem wrong, like you say; I'll open a pull request with a fix and reference this issue in it, so you can check it out. I think one reason why it might be wrong is that we haven't really been using it in our lab for experiments. I simply implemented it one day because I read the M-STDP paper and thought it was an interesting idea.

[KyungsuKim42]

Thank you for fast and kind reply!
I also have found other minor bugs here and there. I'll make pull request when my branch's got stabilized.

[djsaunde]

I'll just leave off with this: the Pipeline object and interface with OpenAI gym is not a focus of our development at the moment, so I expect there will be a lot of bugs (if this is what you are interested in using). I would love any and all pull requests.