Giter Site home page Giter Site logo

Comments (3)

binwiederhier avatar binwiederhier commented on May 4, 2024

So you can obviously subscribe to multiple topics in the app by clicking the + button. So are you talking about

A. Subscribing to multiple topics in the same add dialog box? So that you'd enter a comma separated list and you'd only see one entry in the main view?

B. Or just a more convenient way to add multiple topics at once?

I think it would help if you described your preferred screen flow and text boxes. Sorry I'm just not quite grasping what's missing.

from ntfy.

aslmx avatar aslmx commented on May 4, 2024

Yeah, valid question - sorry, could have given more details!

Actually i thought about usecase A, having multiple topic subscriptions under one entry that can be added at once (and of course later be changed).

I'm not sure how you handle the long running http connection.

I'm not competent to check the source of the app and evaluate it myself, hence asking: would there a be a difference of listening to two topics in one http request (so letting the server decide to send you posts two either of the topic) or querying multiple topcis with it's own separate subscription?

If there is no difference, you might as well just allow adding two topics by comma separation and after the user clicked "Add" separate it into two individual subscriptions.

If it doesn't make any performance difference then I think it is up to you to decide.

Could as well add more UI complexity by asking the user. But i thought the simplest solution is to just copy what you support via WebUi and cURL, which is usecase A.

from ntfy.

binwiederhier avatar binwiederhier commented on May 4, 2024

I'm not sure how you handle the long running http connection. I'm not competent to check the source of the app and evaluate it myself, hence asking: would there a be a difference of listening to two topics in one http request (so letting the server decide to send you posts two either of the topic) or querying multiple topcis with it's own separate subscription?

I made the comma-separated multi-topic subscription especially for the Android app. The app only keeps one connection per host to avoid using double the battery.

Example: If you subscribe to topic1, it'll listen to https://ntfy.sh/topic1/json. If you then add topic2, it'll break the first connection and restart it as https://ntfy.sh/topic1,topic2/json. There is a little bit of UI-trickery to avoid showing that we're reconnecting, but that's what's happening.

If there is no difference, you might as well just allow adding two topics by comma separation and after the user clicked "Add" separate it into two individual subscriptions. If it doesn't make any performance difference then I think it is up to you to decide.

I can absolutely do that, though the "Subscribe to topic" dialog is already too crowded, so I fear another sentence a la "You may enter a comma-separated list to subscribe to multiple topics" is gonna be a little much. I'll experiment a bit. Though I am leaning towards not changing it.

If you're mainly worried about the annoyance of having to re-enter your home-server IP/address, I just added an automatic auto-fill to avoid that (see #13). In this screenshot, the server address is auto-filled, because it's the server that you've already used before. If there's more than one, there's a drop-down too now (this is not released yet):

image

from ntfy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.