Giter Site home page Giter Site logo

Comments (10)

harttle avatar harttle commented on May 31, 2024 2

Seems the error posted above is due to a trailing / instead of \, it's fixed on 9.28.1.

harttle/liquidjs#408

Maybe there's multiple errors, but it helps by posting the (next) exact problem.

from eleventy-garden.

asbjornb avatar asbjornb commented on May 31, 2024 1

Thanks. I will see if I can find something when I get time, but it might be easier to just wait for a fix of the linked issue before spending too much time.

from eleventy-garden.

binyamin avatar binyamin commented on May 31, 2024 1

@asbjornb that would be totally fine. Will do.

from eleventy-garden.

asbjornb avatar asbjornb commented on May 31, 2024

Seems there might be multiple errors. Might have forgotten npm prune while testing - not sure. Can't reproduce the pull request working even when reverting your 3 prior commits and reupping to canary 44. Indeed can't reproduce getting it to work on 44 locally at all it seems. If I either add your quotes to includes, up to .44 or both I am not able to render templates locally.
Not sure if node_modules can be removed from .eleventyignore but can't test much in the current state.

from eleventy-garden.

binyamin avatar binyamin commented on May 31, 2024

@asbjornb Weird. I'll do some poking around. If you find a way to get to get this working, let me know.

from eleventy-garden.

binyamin avatar binyamin commented on May 31, 2024

Thanks @harttle. That's probably the issue, because I can't reproduce it.

from eleventy-garden.

asbjornb avatar asbjornb commented on May 31, 2024

Thanks @harttle !
I'm not completely sure I can utilize it until 11ty references the new version. I tried explicitly adding "liquidjs": "^9.28.1" to my package.json file and then doing a combination of deleting node_modules, npm prune, npm install and then running npm start. Error seems similar but doesn't include absolute path in the log.

[11ty] Problem writing Eleventy templates:
[11ty] Having trouble writing template: _site/about/index.html

`TemplateWriterWriteError` was thrown
  Eleventy:EleventyErrorHandler (error stack): TemplateWriterWriteError: Having trouble writing template: _site/about/index.html
  Eleventy:EleventyErrorHandler     at C:\Projects\testgarden\node_modules\@11ty\eleventy\src\TemplateWriter.js:290:15
  Eleventy:EleventyErrorHandler     at async Promise.all (index 1)
  Eleventy:EleventyErrorHandler     at async Eleventy.executeBuild (C:\Projects\testgarden\node_modules\@11ty\eleventy\src\Eleventy.js:958:13)
  Eleventy:EleventyErrorHandler     at async Eleventy.watch (C:\Projects\testgarden\node_modules\@11ty\eleventy\src\Eleventy.js:809:18) +0ms
[11ty] ENOENT: Failed to lookup "head.html" in "includes", file:./layouts/default.html, line:4, col:5

`RenderError` was thrown
  Eleventy:EleventyErrorHandler (error stack): ENOENT: Failed to lookup "head.html" in "includes", file:./layouts/default.html, line:4, col:5

I will try to see if I can reproduce on another windows pc and then a linux machine tomorrow. The repo I use is at https://github.com/asbjornb/testgarden
I should have forked but had a bit of trouble since I already have a fork - should probably just have branched on that. Can do that tomorrow too.

from eleventy-garden.

asbjornb avatar asbjornb commented on May 31, 2024

It seems the new 11ty beta didn't help although it ups the liquidjs reference. Going back to canary.23 works still. Not sure if this is unrelated to the liquidjs version. Other syntax might have changed in between versions or something. I owe some more tests when I can fin the time.

c:\Projects\personal-site>npm start

> [email protected] start c:\Projects\personal-site
> eleventy --serve --quiet

[11ty] Problem writing Eleventy templates: (more in DEBUG output)
[11ty] > Having trouble writing template: _site/about/index.html

`TemplateWriterWriteError` was thrown
[11ty] > illegal filename "undefined", file:./content/layouts/default.html, line:4, col:5

`RenderError` was thrown
[11ty] > illegal filename "undefined"

`AssertionError` was thrown:
[11ty]     AssertionError: illegal filename "undefined"
        at new AssertionError (c:\Projects\personal-site\node_modules\liquidjs\dist\liquid.node.cjs.js:653:28)
        at assert (c:\Projects\personal-site\node_modules\liquidjs\dist\liquid.node.cjs.js:800:15)
        at Object.<anonymous> (c:\Projects\personal-site\node_modules\liquidjs\dist\liquid.node.cjs.js:3047:21)
        at step (c:\Projects\personal-site\node_modules\liquidjs\dist\liquid.node.cjs.js:84:23)
        at Object.next (c:\Projects\personal-site\node_modules\liquidjs\dist\liquid.node.cjs.js:65:53)
        at reduce (c:\Projects\personal-site\node_modules\liquidjs\dist\liquid.node.cjs.js:1021:25)
        at Object.then (c:\Projects\personal-site\node_modules\liquidjs\dist\liquid.node.cjs.js:989:43)
        at reduce (c:\Projects\personal-site\node_modules\liquidjs\dist\liquid.node.cjs.js:1028:40)
        at toThenable (c:\Projects\personal-site\node_modules\liquidjs\dist\liquid.node.cjs.js:1016:16)
        at reduce (c:\Projects\personal-site\node_modules\liquidjs\dist\liquid.node.cjs.js:1028:16)
[11ty] Wrote 0 files in 0.14 seconds (v1.0.0-beta.5)

and

[11ty] Problem writing Eleventy templates:
[11ty] Having trouble writing template: _site/about/index.html

`TemplateWriterWriteError` was thrown
  Eleventy:EleventyErrorHandler (error stack): TemplateWriterWriteError: Having trouble writing template: _site/about/index.html
  Eleventy:EleventyErrorHandler     at c:\Projects\personal-site\node_modules\@11ty\eleventy\src\TemplateWriter.js:289:15
  Eleventy:EleventyErrorHandler     at async Promise.all (index 1)
  Eleventy:EleventyErrorHandler     at async Eleventy.executeBuild (c:\Projects\personal-site\node_modules\@11ty\eleventy\src\Eleventy.js:960:13) +0ms
[11ty] illegal filename "undefined", file:./content/layouts/default.html, line:4, col:5

`RenderError` was thrown
  Eleventy:EleventyErrorHandler (error stack): illegal filename "undefined", file:./content/layouts/default.html, line:4, col:5
  Eleventy:EleventyErrorHandler    2| <html lang="en">
  Eleventy:EleventyErrorHandler    3| <head>
  Eleventy:EleventyErrorHandler >> 4|     {% include head.html %}
  Eleventy:EleventyErrorHandler    5| </head>
  Eleventy:EleventyErrorHandler    6| <body>
  Eleventy:EleventyErrorHandler    7|     <header class="page-header">
  Eleventy:EleventyErrorHandler RenderError: illegal filename "undefined", file:./content/layouts/default.html, line:4, col:5

from eleventy-garden.

asbjornb avatar asbjornb commented on May 31, 2024

Updating to beta then readding the quotes on <% include-statements seems to have solved this. I'm not sure if upping the dependency in eleventy garden to the beta version would be ok with you but it would close this issue :)

from eleventy-garden.

binyamin avatar binyamin commented on May 31, 2024

commit 1c7ce82 should fix this

from eleventy-garden.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.