Labels

[benbro]

Labels

[biochem-fan]

Hi,
Labeling is implemented in 'labelling' branch.
https://github.com/biochem-fan/GLmol/tree/labelling

Demo: http://webglmol.sourceforge.jp/labelling/viewer.html
(Click an atom to identify it)

[benbro]

Thank you for your quick response.

Nice demo.
There are several issues there:
When you click several times on the same atom, it adds the label several times.
No way to remove the label.
Now way to display all labels.
Sometimes the label is 'Undefined'.

Any chance the labeling branch can be merged with master?
And maybe update three.js and jquery to the latest version?
This is an attempt to update to r64 (three.js is at r68 now)
alexmasselot@7f2cc79

[biochem-fan]

Actually, labeling itself is OK. The problem is in the 'click-to-identify' feature.
That is, if you know which labels are needed beforehand, it works perfectly.
Dynamic labeling (adding / removing labels interactively) is more difficult.

Why do you want to update THREE.js?
They are getting larger and larger, and I don't need new features.

In future, I would like to make GLmol independent from THREE.js.
I am also planning to refactor everything to allow dynamic update of the
scene (like labeling, re-coloring) without costly scene rebuilding. But
I don't have time to work on it right now.

[benbro]

Thank you.

[benbro]

Can I contribute somehow?
How large are the tasks of making GLmol independent from THREE.js
and allowing dynamic updates of the scene?

Does jsmol uses GLmol?

[biochem-fan]

Thank you very much for your offer.
However, it is more of "architecture design" than simple implementation work.

JSmol uses very small fraction of GLmol's code.