Comments (5)
yes, tiktorch's model adapters, or even the PredictionPipeline with pre- and postprocessing.
But each such adapter/pipeline/runner potentially goes together with it's own set of transformation implementations...
We could merge it all, but then we should have kept everything in python-bioimage-io.
I think some splitting makes sense and the spec just happens to live in python, but I see that more like a coincidence. we could scratch the whole validator and go json schema, who knows?^^
Example use cases could live there though, but not full implementations for several frameworks (and languages!?). Maybe merging pytorch-bioimage-io into python-bioimage-io (but keeping the separate modules bioimageio.core and bioimageio.torch as it is now) would make sense.
- bioimageio.spec:
python-bioimage-io-> spec-bioimage-io - bioimageio.core: python-bioimage-io
- bioimageio.torch: pytorch-bioimage-io -> python-bioimage-io?
- bioimageio.tf: -> python-bioimage-io?
from core-bioimage-io-python.
(Also, if we keep this repository and move pytorch-bioimage-io
and stuff from tiktorch here, we should remove the outdated stuff in https://github.com/bioimage-io/python-bioimage-io/tree/master/bioimageio).
from core-bioimage-io-python.
There is not much left here, but
- the runner should live here (still in tiktorch atm)
- the transformations should be updated and live here (for numpy only as there is clear overlap with [bioimageio.torch](https://github.com/bioimage-io/pytorch-bioimage-io and potentially with a 'bioimageio.tf')
from core-bioimage-io-python.
- the runner should live here (still in tiktorch atm)
What exactly do you mean by runner? This: https://github.com/ilastik/tiktorch/tree/master/tiktorch/server/prediction_pipeline/_model_adapters?
- the transformations should be updated and live here (for numpy only as there is clear overlap with [bioimageio.torch](https://github.com/bioimage-io/pytorch-bioimage-io and potentially with a 'bioimageio.tf')
For these, I thought that the spec repo would also be the better place, because they could serve as reference implementations.
from core-bioimage-io-python.
yes, tiktorch's model adapters, or even the PredictionPipeline with pre- and postprocessing.
But each such adapter/pipeline/runner potentially goes together with it's own set of transformation implementations...
We could merge it all, but then we should have kept everything in python-bioimage-io.
I think some splitting makes sense and the spec just happens to live in python, but I see that more like a coincidence. we could scratch the whole validator and go json schema, who knows?^^
I agree that some separation makes sense, but I don't think having separate repositories for python-bioimage-io
, pytorch-bioimage-io
and tf-bioimage-io
make sense, especially since the prediction pipelines depend on having the frameworks available, so I very much like this idea:
- bioimageio.spec: -> spec-bioimage-io
- bioimageio.core: python-bioimage-io
- bioimageio.torch: pytorch-bioimage-io -> python-bioimage-io?
- bioimageio.tf: -> python-bioimage-io?
I still think that the the pure numpy implementations of pre-and-postprocessings should go into the spec repository and serve as the reference implementation. Then, the spec repo is self-contained and python-bioimage-io
depends on it anyways, so can use these transformations.
from core-bioimage-io-python.
Related Issues (20)
- validate (citation) dois
- VALUE is not a is not a valid RESUNIT HOT 12
- Better default io names in build_model() HOT 12
- Implement sha256 check for the model
- MONAI translation to BioImage format HOT 1
- Image normalization causing test_model test failure HOT 3
- Provide our CI testing environment as docker containers
- Reproducibility test for model creation fails HOT 3
- Hackathon 2023/10 notes HOT 2
- programmatic access for datasets
- Add support for release candidates and automatic mail updates
- developer documentation
- Investigate integration of aicsimageio
- Add/improve weight converters
- Loading model resource gives assertion error HOT 2
- Link in example broken HOT 1
- Running `test_model` raises TypeError: list indices must be integers or slices, not str HOT 1
- Improve weights conversion to ONNX HOT 1
- bug when `add_deepimagej_config=True` in `build_model` HOT 5
- Error when importing HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core-bioimage-io-python.