Comments (4)
This is likely caused by the fact that currently GO annotations are not available in the Monarch golr index, they are available via the AmiGO golr, which follows a different schema.
Now we could have simply left the client to navigate two different APIs, but one of the goals of biolink is to provide a high level API that can be used over different databases, at least those that are similar enough, and to provide a convenient one-stop-shop endpoint.
Currently the reference implementation of biolink will introspect the category to determine how to route the query behind the scenes. This all works if you stick to the high-level categories exposed by biolink. Here "function" is the category that encompassed all GO annotation (this is potentially confusing: the GO cell component hierarchy represents material entities not function, but the semantics of the association if of functional association).
Monarch uses more granular categories, but the biolink contract (which needs to be better documented) is for a smaller set of categories
I think it's going to be most straightforward if you implement this as two calls. E.g.
def exec(...):
if bidirectional:
assocs1 = self.exec(bidirection=False, subject=subject, ...)
assocs2 = self.exec(bidirection=False, object=subject, ...)
return assocs1+assocs2
this is perhaps less efficient but the stratification simplifies the logic as you don't need to mesh your OR logic with the logic of how the queries are implemented.
from ontobio.
I'll leave open as a placeholder for improving the docs here. Comments from @kshefchek and others welcome
from ontobio.
That could work, the only problem is that it would make pagination more awkward. What I could do is get half a page from the one, and half a page from the other. But then it would be possible, and probably even common, to receive much less than a full page of data. I've been trying to avoid this (we've run into this sort of thing before), but maybe it's not worth the effort.
from ontobio.
good point. I don't have a satisfactory answer yet...
from ontobio.
Related Issues (20)
- Changes to rdfgen/gocamgen for handling new date fields
- What does this repo do? Please improve the readme
- GAF evidence code to ECO conversion: always use gaf-eco-mapping.txt PURL
- Unknown GAF qualifier/relation breaks parser HOT 1
- get_minimal_subgraph gives "RecursionError: maximum recursion depth exceeded"
- ModuleNotFoundError: No module named ‘ontobio.graph_io'
- Emit creation-date on Evidence individuals HOT 1
- error in gocamgen HOT 1
- Obsolete GO term with no replacement breaks with/from validation HOT 2
- pyparsing upgrade causes AttributeError HOT 1
- ogr bug? HOT 1
- loading local json files fails HOT 1
- ontobio output to obograph?
- Cannot render subgraphs using GraphRenderer
- GO-CAM translation should convert 'transports or maintains localization of' and other relations HOT 3
- "category" field in Token should be "categories"
- Converting GPAD to GAF can result in blank evidence codes if no ECO-to-GAF mapping exists HOT 2
- Use gaf-eco-mapping-derived.txt in EcoMap in GpadParser and GafWriter HOT 2
- EcoMap should parse eco.owl as ontology HOT 1
- enrichment_test() function not returning anything
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ontobio.