💅 useFilenamingConvention and multiple ignore statements collide

[zauni]

💅 useFilenamingConvention and multiple ignore statements collide

[Sec-ant]

If I use the useFilenamingConvention rule and I have a filename that is not compatible with this rule it is possible to ignore that.
E.g. Expo Router has the convention of using [] in the filename to indicate path parameters. But this is not a problem when I use the comment // biome-ignore lint/style/useFilenamingConvention: expo router convention

This looks like a bug to me because // biome-ignore is for ignoring a code line instead of a file. And the repoduction you provide seems the correct behavior.

If you want to ignore a rule for a specific set of files, you should use overrides.

[zauni]

Ah, that of course makes much more sense. Funny that it worked with just one // biome-ignore 🙂

So I will close this one as the overrides is sufficent for this use case.
Thanks for the explanation and links!

[Conaclos]

Ah, that of course makes much more sense. Funny that it worked with just one // biome-ignore 🙂

It works because internally, the rule queries the root node of a file. Not sure why this doesn't work when there are multiple biome-ignore comments.

[zauni]

So for anybody looking for a solution, add this to your biome.json

"overrides": [
  {
    "include": ["**/[[]*].tsx"],
    "linter": {
      "rules": {
        "style": {
          "useFilenamingConvention": {
            "level": "off",
            "options": {}
          }
        }
      }
    }
  }
]

The include pattern looks a bit weird, but it includes every file with brackets like e.g. [something].tsx or [...spread].tsx is included

[ematipico]

It would be great to have this in our documentation.