Giter Site home page Giter Site logo

Comments (4)

Conaclos avatar Conaclos commented on September 22, 2024

It is the intended behavior. Here formatObject is not initialized and is assigned once. You can turn the single assignment into an initialization.

from biome.

Stanzilla avatar Stanzilla commented on September 22, 2024

It is the intended behavior. Here formatObject is not initialized and is assigned once. You can turn the single assignment into an initialization.

How do you mean? I did it like that because of the recursion.

from biome.

Conaclos avatar Conaclos commented on September 22, 2024

What preventing you of writing the code like this:

const format = (variableName: string, source: unknown) => {
  const formatObject = (src: Record<string, unknown>) =>
    Object.keys(src)
      .map((property) => formatObjectProperty(property, src[property]))
      .join('');

  const formatObjectProperty = (propertyName: string, content: unknown) => {
    let output = '';

    switch (typeof content) {
      case 'string':
        output = `[=[${content}]=]`;
        break;
      case 'object':
        output = `{ ${formatObject(content as Record<string, unknown>)} }`;
        break;
      case 'undefined':
        output = `""`;
        break;
      default:
        throw new Error(
          `Unknown type (${typeof content}) of property "${propertyName}"!`,
        );
    }

    return `["${propertyName.replace(/\\/g, '')}"] = ${output},\n`;
  };

  const output = formatObject(source as Record<string, unknown>);

  return `${variableName} = {\n${output}\n}`;
};

export default format;

from biome.

Stanzilla avatar Stanzilla commented on September 22, 2024

What preventing you of writing the code like this:

const format = (variableName: string, source: unknown) => {
  const formatObject = (src: Record<string, unknown>) =>
    Object.keys(src)
      .map((property) => formatObjectProperty(property, src[property]))
      .join('');

  const formatObjectProperty = (propertyName: string, content: unknown) => {
    let output = '';

    switch (typeof content) {
      case 'string':
        output = `[=[${content}]=]`;
        break;
      case 'object':
        output = `{ ${formatObject(content as Record<string, unknown>)} }`;
        break;
      case 'undefined':
        output = `""`;
        break;
      default:
        throw new Error(
          `Unknown type (${typeof content}) of property "${propertyName}"!`,
        );
    }

    return `["${propertyName.replace(/\\/g, '')}"] = ${output},\n`;
  };

  const output = formatObject(source as Record<string, unknown>);

  return `${variableName} = {\n${output}\n}`;
};

export default format;

Ah yes, I just figured my case was worth a report, but you are right, it does make sense!

from biome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.