Giter Site home page Giter Site logo

Comments (6)

mbacalan avatar mbacalan commented on July 21, 2024 2

Hi, could you please share a repo for us to reproduce the issue more easily?

Yes, there you go: https://github.com/mbacalan/biome-brackets-bug

from biome.

Sec-ant avatar Sec-ant commented on July 21, 2024 2

I'm able to reproduce this on a windows machine, thanks for providing the repro!

from biome.

Sec-ant avatar Sec-ant commented on July 21, 2024 1

I think this is a lefthook bug or misuse, I added a debug output to print the file path Biome received:

  • On a Linux machine or WSL, the path passed to the Biome CLI is "src/orders/[order-id]/index.tsx":
    image

  • On a Windows machine, the path passed to the Biome CLI is "\'src/orders/[order-id]/index.tsx\'":
    image

I'm afraid there isn't much Biome can do. Maybe you should create an issue there or try another tool.

from biome.

mbacalan avatar mbacalan commented on July 21, 2024

It appears that running C:\Users\foo\bar\node_modules\.bin\biome format --write --no-errors-on-unmatched --files-ignore-unknown=true 'path/to/[parameterized]/file.tsx' directly in terminal works as expected, even on Windows.

I'm not sure then if this is caused by Biome running as part of a Git hook or if its something to do with Lefthook.

from biome.

Sec-ant avatar Sec-ant commented on July 21, 2024

Hi, could you please share a repo for us to reproduce the issue more easily?

from biome.

mbacalan avatar mbacalan commented on July 21, 2024

Thanks for looking into this! I'll create a bug report for Lefthook.

from biome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.