Comments (12)
actual PR for using ints instead of floats; #58
from bitcoin-lib-php.
also I'd like to go and replace most places where we return false
and throw exceptions.
and maybe add a custom exception class instead of \Exception
?
from bitcoin-lib-php.
maybe you can make a v1.1
branch and already merge the stuff that's gonna go in there, then we can do PRs onto that instead of onto master and have less conflicts in the end?
from bitcoin-lib-php.
well the right thing to do is create a 1.0
branch (dont use v
prefix for branches) so we can maintain 1.0.x
and the new stuff goes into master
.
from bitcoin-lib-php.
okay, so @btcdrak @afk11 you guys agree to add a BitcoinLibException and start throwing it everywhere?
from bitcoin-lib-php.
Generally a custom exception makes no sense. There are plenty semantic ones to choose in PHP.
from bitcoin-lib-php.
Okay, but replacing all the silent return false
stuff with exceptions you agree with right?
from bitcoin-lib-php.
@rubensayshi Yes: false
should only be returned when a function processes something and returns false on valid input. If invalid inputs were received or something unexpected happened, it should always be an exception. This allows errors to bubble up the API. Returning false
when something fails is definitely semantically wrong.
from bitcoin-lib-php.
PR's #59 and #60 bring the library up to date with the latest phpecc commit and should be producing minimal pushdata ops.
I've added the throw exceptions issue to the list of tasks
@btcdrak we have a few releases along v1.0.x
already. I'll create a branch called 1.0, tag it as v1.0.6, and when we merge these commits we'll start following 1.1.0
from bitcoin-lib-php.
Another PR to throw exceptions as much as possible; #61
from bitcoin-lib-php.
Nice one! Looks like we have everything we wanted now. I'll merge these now and create one last branch of 1.0.
from bitcoin-lib-php.
This has been merged and tagged as 1.1.0 https://github.com/Bit-Wasp/bitcoin-lib-php/releases/tag/1.1.0
from bitcoin-lib-php.
Related Issues (20)
- How i can list unspent transaction for any private key of address. HOT 5
- Electrum 2.0 xpub HOT 3
- parse error HOT 4
- installation problem HOT 2
- bits -> difficulty? HOT 2
- Feature Request: capability to derive all (used) wallet keys from public master key. HOT 3
- How to use createrawtransaction and set fees? HOT 18
- electrum HOT 1
- decode fails to read a vout HOT 2
- RawTransaction::decode will fail on version numbers that are not equal to 1.
- Support OP_RETURN transaction ?
- Unnecessary cast in toBTC()
- implement BIP173 - SegWit HOT 5
- Generating change address from publicKey Bip44, Bip43
- Function mcrypt_create_iv() is deprecated HOT 1
- Namespace Issue HOT 3
- Is it possible to create Segwit addresses? HOT 1
- Ignore - Delete
- other coins wallet
- Replace mdanter/ecc with paragonie/ecc
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitcoin-lib-php.