Handling of GIF_EMPTY_FRAME error is confusing for user

[bitbank2]

Handling of GIF_EMPTY_FRAME error is confusing for user

[bitbank2]

I just pushed a change which adds support for interlaced frames and addresses the issue you raise here. Please give it a try and if you're satisfied, I'll do a new release.

[embedded-creations]

@bitbank2 that seems to fix the issue where delayMilliseconds is left unset, but actually makes it worse for me wanting to know if a frame was processed. Can you also keep the GIF_EMPTY_FRAME error, and don't replace with GIF_SUCCESS, or do you have another suggestion on how to know if a frame was processed after calling playFrame()?

[bitbank2]

ok, please try again. I believe I have patched the last hole in the logic.

[embedded-creations]

@bitbank2 The issue is still here in playFrame() (not in the C interface which I'm not using):

https://github.com/bitbank2/AnimatedGIF/blob/master/src/AnimatedGIF.cpp#L196

GIF_EMPTY_FRAME gets changed to GIF_SUCCESS, so it looks like a frame was processed, but it wasn't and there's no way for me to know the difference.

[bitbank2]

You're right - I was working with the C code. I removed the offending line. If that's not it, please make the change and do a pull request.

[embedded-creations]

Great! I'll test this and an interlaced GIF as well and let you know

[embedded-creations]

Needed one more line of code, and I also added some comments so just did a PR. Feel free to copy/paste if that's easier than accepting the PR #23

I tested the interlaced GIFs @PaintYourDragon posted in #14 and they work. I didn't really look at the C code changes nor try to test them, LMK if you want me to specifically look at those.

[bitbank2]

Thanks for the changes - accepted.