UI: Currency conversion doesn't work (CryptoCompare Rate Limit on VPN)

[lclc]

UI: Currency conversion doesn't work (CryptoCompare Rate Limit on VPN)

[x1ddos]

We moved to another service in #1196 which should resolve this issue. The change is expected to make into the next release planned later this month.

[x1ddos]

Once suggestion I have is to replace CryptoCompare with getting rates directly from an exchange or even multiple to let the users choose.

Here's one list of exchanges I found, sorted by their market share: https://data.bitcoinity.org/markets/exchanges/all/30d#rank_desc

[benma]

It would be nice to have one service to get all rates from, instead of having to call multiple different servers. Maybe not a big deal though.

We might want to show historical rates too at some point. Cryptocompare provides those afaik. Not sure if exchanges provide them as well, or how far back if they do.

[x1ddos]

One alternative maybe is just use something else instead of CryptoCompare? Like https://www.coingecko.com/en/api.

[lclc]

@x1ddos I'm sure all of them have rate-limiting.

This might be a rather exotic problem anyway.

[x1ddos]

Sure, everything is rate-limited. Yet, some would allow us to set up a caching proxy to resolve this issue, others wouldn't. According to their terms&conditions anyway. That is the difference I'm looking for.

…

On Sat, 1 Aug 2020, 11:31 Lucas Betschart, ***@***.***> wrote: @x1ddos <https://github.com/x1ddos> I'm sure all of them have rate-limiting. This might be a rather exotic problem anyway. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#942 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAGGPN5QRSOJBRSDV7QKQ3R6POH3ANCNFSM4PP2KSBQ> .

[thisconnect]

Got released 🎉 thanks @x1ddos and @benma !