Giter Site home page Giter Site logo

Comments (9)

ventz avatar ventz commented on May 6, 2024 7

@kspearrin Fair enough. I also jumped the gun and made the comment before I started poking through the project and seeing that everything else is MS/ASP -- which again, given that makes a lot more sense.

I saw the comment from earlier about modifying it for another DB engine, but it seems some of the info has changed (ex: line 62 linked). Would it be possible to give me some info about what needs to be ported -- I would be happy to port to mariadb/mysql.

from server.

kspearrin avatar kspearrin commented on May 6, 2024 3

@ventz reason is simply because I have about 10 years of professional experience with MS SQL and no experience with any other engine. So I use what I know.

from server.

kspearrin avatar kspearrin commented on May 6, 2024

This is actually very easy for anyone to do.

The project has a data access layer using the repository pattern. Data access is written against a few repository interfaces (see https://github.com/bitwarden/core/tree/master/src/Core/Repositories) that is isolated from all other business logic of the application. Once you write to those interfaces all you need to do is change the DI registration of those interfaces to your DB engine implementation and you're done (see https://github.com/bitwarden/core/blob/master/src/Api/Startup.cs#L62).

from server.

kspearrin avatar kspearrin commented on May 6, 2024

Closing this since this is not something I plan on implementing but is very possible given the above ^.

from server.

MosabHD avatar MosabHD commented on May 6, 2024

Hi
have you heard of anyone who tried to implement this and worked for him?
unfortunately I am not experienced in this field and I want to have bitwarden on mysql.

from server.

cloverzrg avatar cloverzrg commented on May 6, 2024

Mssql takes up too much memory

from server.

jsaathof avatar jsaathof commented on May 6, 2024

I have a PostgreSQL database. I would like to have that driver implemented.

from server.

Mart124 avatar Mart124 commented on May 6, 2024

https://community.bitwarden.com/t/use-other-database-than-mssql/612

from server.

ventz avatar ventz commented on May 6, 2024

Personally, I can't believe that an open source project chose mssql as the DB driver...forget that it's 1.3GB just for the mssql container while the other bitwarden containers are ~200-300MBs. This has nothing to do with "mssql vs others" -- mssql server on linux is not at all mature (https://www.techrepublic.com/article/microsoft-continues-open-source-love-fest-announces-sql-server-on-linux/). MariaDB/MySQL/PosgreSQL/SQLite all make sense here given how much use and abuse they have handled. Was there a specific reason for using MSSQL?

edit: to be fair, it's an MS/ASP project...which I now see. I guess it makes more sense given that, but MS SQL in Docker is still very immature.

from server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.