Giter Site home page Giter Site logo

Comments (21)

bkw777 avatar bkw777 commented on July 23, 2024 2

Only other kind of changelog I can find, that we could fetch automatically, is the actually full every-single-detail changelog from upstream, not a nice summary. Ex:
https://cdn.kernel.org/pub/linux/kernel/v5.x/ChangeLog-5.6.17

from mainline.

bkw777 avatar bkw777 commented on July 23, 2024 2

actually, looking at the old CHANGES vs the upstream Changelog, looks like the old CHANGES format can be parsed out of the upstream changelog without too much trouble:
Compare a single item from:
https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.6.17/CHANGES
https://cdn.kernel.org/pub/linux/kernel/v5.x/ChangeLog-5.6.17

upstream version:

commit 897b7c720803aacf7c94a0054648210d7c737f06
Author: DENG Qingfang 
Date:   Wed May 13 23:37:17 2020 +0800

    net: dsa: mt7530: set CPU port to fallback mode
    
    commit 38152ea37d8bdaffa22603e0a5b5b86cfa8714c9 upstream.
    
    Currently, setting a bridge's self PVID to other value and deleting
    the default VID 1 renders untagged ports of that VLAN unable to talk to
    the CPU port:
    
            bridge vlan add dev br0 vid 2 pvid untagged self
            bridge vlan del dev br0 vid 1 self
            bridge vlan add dev sw0p0 vid 2 pvid untagged
            bridge vlan del dev sw0p0 vid 1
            # br0 cannot send untagged frames out of sw0p0 anymore
    
    That is because the CPU port is set to security mode and its PVID is
    still 1, and untagged frames are dropped due to VLAN member violation.
    
    Set the CPU port to fallback mode so untagged frames can pass through.
    
    Fixes: 83163f7dca56 ("net: dsa: mediatek: add VLAN support for MT7530")
    Signed-off-by: DENG Qingfang 
    Reviewed-by: Florian Fainelli 
    Signed-off-by: David S. Miller 
    Signed-off-by: Greg Kroah-Hartman 

old summary version:

DENG Qingfang (1):
      net: dsa: mt7530: set CPU port to fallback mode

I'll have to look around some more at other versions to see what the (1) is. Maybe the number of items from that same submitter? This particular example might make the job look falsely simpler than it is, just because it happens that in this case every submitter had a single item, where maybe the script that made the old summaries did a little bit of collating and collapsing. That still wouldn't be too bad, and we don't necessarily have to replicate that immeditely. It would probably be fine to just do the simple job of just removing some of the git details, and maybe even keep some of those more verbose descriptions even though they weren't in the old summaries.

In fact, in the real short term, it's probably good enough to just make the button launch the link to the upstream changelog.

from mainline.

bkw777 avatar bkw777 commented on July 23, 2024 1

There is definitely something wrong with the way the version strings are parsed and compared against each other in the latest version. I am working on a re-write of all the stuff related to that, but until then I think one version back is still ok. Sorry.

from mainline.

Deleetdk avatar Deleetdk commented on July 23, 2024

It's not just the 5.7.X that are missing. It's missing newer versions of the older releases too. Here's a comparison with the results in Ukuu paid.

Screenshot from 2020-06-22 15-20-47
Screenshot from 2020-06-22 15-20-35
Screenshot from 2020-06-22 15-20-25

from mainline.

reid-rigo avatar reid-rigo commented on July 23, 2024

I assumed these versions were missing because of failing builds: https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.7.5/

Test amd64/self-tests failed (rc=2, on=amd64, time=0:01:02, log=amd64/self-tests/log)

from mainline.

TID41 avatar TID41 commented on July 23, 2024

The URL of the actual .deb files has changed. They've added 'amd64' after the version number (for x64 kernels, of course) for everything newer than June 7:

https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.7.1/linux-image-unsigned-5.7.1-050701-generic_5.7.1-050701.202006071230_amd64.deb
https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.7.2/amd64/linux-image-unsigned-5.7.2-050702-generic_5.7.2-050702.202006101934_amd64.deb

from mainline.

StatusCode404 avatar StatusCode404 commented on July 23, 2024

Hi @bkw777; thanks for the fork and trying to fix the bug! So has it been fixed? If so we'll need the ppa updated as well.

Thanks again

from mainline.

noah1510 avatar noah1510 commented on July 23, 2024

It seems like #44 fixes it you can download the source from https://github.com/tovam/mainline and build the package yourself or wait until the pull request is merged.

If you want to manually update the package follow the build instructions of the readme, but instead of running make and make install run sudo apt-get install devscripts debhelper, debuild -uc -us and sudo dpkg -i ../mainline_1.0.12_amd64.deb. This will build the debian package from source and install it (basically a manual update).

from mainline.

StatusCode404 avatar StatusCode404 commented on July 23, 2024

Is the PPA automated? Can we expect the PPA updated soon?

from mainline.

noah1510 avatar noah1510 commented on July 23, 2024

Is the PPA automated?

I don't really think so although the changelog always says automatic build 🤷‍♂️

Can we expect the PPA updated soon?

Probably, however I think there will be a new version soon and after that the ppa should be updated.
Edit: The ppa is not maintained by bkw777 rather by @cappelikan so it depends on when he wants to update the ppa.

from mainline.

cappelikan avatar cappelikan commented on July 23, 2024

Чи PPA автоматизовано?

Я не думаю, що так, хоча журнал змін завжди говорить про автоматичну збірку

Чи можемо ми очікувати, що скоро буде оновлено PPA?

Напевно, проте я думаю, що незабаром з'явиться нова версія, після чого ppa має бути оновлений.
Редагувати: ppa не підтримується bkw777, а не @cappelikan, тому це залежить від того, коли він хоче оновити ppa.

mainline ppa is automatic compile and build deb

from mainline.

noah1510 avatar noah1510 commented on July 23, 2024

Okay good to know, the latest version shows the newer kernels but as I commented on #44 the changes and remove button do not work for those versions or rather cannot be clicked

from mainline.

StatusCode404 avatar StatusCode404 commented on July 23, 2024

Same for me, I can finally see the newer versions but I can't view the release note "changes". The button is greyed out.

from mainline.

StatusCode404 avatar StatusCode404 commented on July 23, 2024

@bkw777 just wondering if you saw our note on the "changes" button being greyed out for the newer kernels?

from mainline.

tovam avatar tovam commented on July 23, 2024

Mainline can't do anything about this problem: the CHANGES file aren't published anymore on kernel.ubuntu.com
Before: https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.6.17
After: https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.6.18

from mainline.

bkw777 avatar bkw777 commented on July 23, 2024

We can detect that and disable the button, or display an explaination in place of the file, or fetch the changes from somewhere else.

from mainline.

StatusCode404 avatar StatusCode404 commented on July 23, 2024

I'll check the mailing list to see why it isn't included anymore.

You can join the ubuntu kernel mailing list here: https://lists.ubuntu.com/mailman/listinfo/kernel-team
to put pressure on them to sort it out. Release Notes are always mandatory if you think about it.

from mainline.

noah1510 avatar noah1510 commented on July 23, 2024

What about the remove button? Do you know why it is greyed out?
Edit: I just noticed it is only greyed out for the running kernel which makes sense 😅

Release Notes are always mandatory if you think about it.

I totally agree especially when it comes to core components of an operating system.

We can detect that and disable the button, or display an explaination in place of the file, or fetch the changes from somewhere else.

+1 for at least showing an explanation.

from mainline.

StatusCode404 avatar StatusCode404 commented on July 23, 2024

I have asked the question here: https://lists.ubuntu.com/archives/kernel-team/2020-July/111962.html

If someone could reply to that advising that you are also experiencing the same problem then that would hopefully catch one of their team's eyes and add pressure on them to fix it.

from mainline.

bkw777 avatar bkw777 commented on July 23, 2024

Moving the changelog issue to it's own new issue #48

from mainline.

bkw777 avatar bkw777 commented on July 23, 2024

Fixed by 9920fab

from mainline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.