Best approach to retrieving Access Token from AWS Request

[black-bits]

Best approach to retrieving Access Token from AWS Request

[ryzr]

Hmmm, so I guess this is the only block with the Result object available:

https://github.com/black-bits/laravel-cognito-auth/blob/master/src/Auth/CognitoGuard.php#L42-L63

Possibly a contract and trait could be created - which provides a method to temporarily store the result on the user object. In pseudo-code, something like:

protected function hasValidCredentials($user, $credentials)
{
    ...

    if ($user instanceof CognitoAuthenticable) {
        $user->setCognitoResult($result)
    }
}

And then in your LoginController, usage would look like:

    /**
     * The user has been authenticated.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  mixed  $user
     * @return mixed
     */
    protected function authenticated(Request $request, $user)
    {
        $result = $user->getCognitoResult();
        $accessToken = $result ? $result['AccessToken'] : null;
    }

Alternatively, the result could be saved inside the guard? The only iffy thing about this, is IDEs wouldn't really understand auth()->cognitoResult() and Auth::cognitoResult()

What do you think?

note: I'm not a maintainer here - but I'm certainly interested in this package and its future development

[bluehaoran]

Thanks @ryzr ! At first glance, that's definitely much better than my first, second, or third thought. I'll think on it for a little longer, and then I will probably go down your route.