Breaks on FF 126b1

[JaneValleyhasBtaken]

Breaks on FF 126b1

[black7375]

Thank you for the report. It was a great help in resolving the bug.

[testitus]

I added the #880 's commit to my chrome directory, and it indeed resolved the white outline tab issue.

But there is no change to the URL suggestions box issue.

[black7375]

Hello, this problem is solved at v8.6.1?
I expect fixed it.

[black7375]

Is it the spacing in the URL view or the color?
Could you describe a little more?

[testitus]

I have the same issue, it is the spacing.

Basically, the top of the URL suggestions box is starting over the top of the screen.

I also noticed the container of the selected tab is now fully surrounded by a thin white line (that is on top of the coloured line).

It started with Firefox v126.0b1; still present with v126.0b3

I'm on Win10, with the Photon style.
I reinstalled the theme from Github, without modifying user.js .

URL spacing issue:

White outline issue:

[black7375]

Thank you for the information.
The tab issue seems to have been fixed after #880 's commit!!

The URL View position issue does not appear in Nightly, so I'll take a closer look.

[JaneValleyhasBtaken]

Yes #880 doesn't work for me on the URL spacing issue.

[black7375]

I failed to reproduce.
I installed Firefox beta (126b) on Windows 10 and used the latest commit.

Could you explain a little more about the reproduction conditions and methods?

[testitus]

Basically, both issues started when Firefox updated to v126.0b1.
As stated, manually adding #880 's commit resolved only the tab issue.

I tried with all my extension disabled (including a header theme), with the master "Original Lepton" style, and that issue is still there.

When I deactivated Firefox UI Fix (starting Firefox in a clean state), the issue disappeared; which tells me it comes from Firefox UI Fix.

I am on Win10 Pro,
I attached a copy of some of my about:support info (translated most of it back in English).

about_support_info.txt

[black7375]

Yes, there seems to be a problem with my theme. To be precise, I have no idea under what situation the problem occurs.

Like the following comment, it is likely to happen in special situations. (I should have left something out.)
#643 (comment)

0. Install Lepton
1. Open "Customize toolbar..." and remove the "New tab" icon from the tab bar
2. Pin a tab
3. Ctl+T several times until your tabs fill the width of the window ... et voilà

0. Install 126.0b3
1. Install lepthon with From Latest Code
2. Try normal state, tab scrollbar mode, use fixed tab, etc..

I think this is a serious bug and I really want to fix it.

[testitus]

So, to try to pinpoint the "special situation", I did a clean install of Firefox (uninstall+delete any remaining Mozilla appdata folders+reinstall from scratch).

... and the issue disappeared.

I guess it is indeed a case of a "special situation", but of Firefox messing up something when updating itself.

My order of operations :
1- Clean install of Firefox / not enabling any plugins or addons;
2- Installed Firefox UI***
3- Enabling addons one by one, with a restart of Firefox in-between each --> the "New Tab Tools" addon was enabled last
4- Enabling a custom "Theme" (under the "Extensions & themes" section, in Settings)
5- Customizing Firefox toolbar (through "Customize toolbar…")
6- Fully syncing any remaining options from my Mozilla/Firefox account.

-- First done with the current master branche of FirefoxUI
-- Then I repeated 1 to 6, but with the current photon-style branche (date Feb 19th); then I manually installed #880 's commit on top of it.

*** In the installation guide, it could be useful to add a note that in about:config, the option "toolkit.legacyUserProfileCustomizations.stylesheets" needs to be set to "true", and that should be done before installing Firefox UI.

[JaneValleyhasBtaken]

it seems like turn userChrome.padding.urlbar to false fix this issue.
Yep, for me, this is fixed

[black7375]

it seems like turn userChrome.padding.urlbar to false fix this issue.

I think I figured it out thanks to your hints.
The --urlbar-toolbar-height value in the URL bar padding file has recently disappeared from upstream.

mozilla/gecko-dev@43665f4

This seems to be a problem in touch density mode or when using a tablet.

[JaneValleyhasBtaken]

Hi
I have tried and confirm it is fixed