Comments (7)
Things have indeed been working well! Thanks for the discussion and the fixes.
from wdi-rs.
Indeed, this does currently require nightly compiler. AFAIK this feature is on it's way to be stabilized so this requirement should disappear eventually. If I understood @Qyriad correctly it should be possible to work around this and not need nightly. But I am not sure about the details.
from wdi-rs.
Correct. All the instances of .exit_ok().expect("msg_here")
can be replaced with something like:
let success = cmd
.status()
.unwrap()
.success();
if !success {
panic!("msg_here");
}
Iirc at the time the Windows build required nightly anyway, but I think that's no longer the case.
from wdi-rs.
Thank you very much for the clarification @Qyriad :)
@xobs there are two ways we can approach it. We either change the code to remove the nightly requirement for now, but then we will probably not even notice when the feature becomes stable. Or we can leave it and just keep using the nightly for now. I did not make my mind up yet which solution is a better one.
I could subscribe to the issue on rust-lang that you provided and monitor it. And keep a tracking issue for us to clean up the code eventually when the nightly feature becomes stable.
What are your suggestions and preferences?
from wdi-rs.
I don't know when Rust will stabilize that feature. They tend to take a very long time, so it could be months. Meanwhile, it's a relatively simple patch, and I can confirm that #2 builds just fine on Rust 1.65.0.
Unless there's a reason to keep the nightly requirement for this feature -- for example ensuring that beginner developers don't build this themselves -- then I don't see the benefits of requiring nightly.
from wdi-rs.
Ok sounds good. I have reviewed, approved and merged #2. @xobs let me know if there are any more issues building on windows. Otherwise we can close this issue.
from wdi-rs.
We're looking to tagging v0.1.0 so we can run a publication cycle to crates.io, as you've not posted anything further, may we assume that things have been working well for you and we can close this xobs?
from wdi-rs.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wdi-rs.