Giter Site home page Giter Site logo

Comments (14)

blacktop avatar blacktop commented on July 18, 2024

@t0rr3sp3dr0 ?

from ipsw.

blacktop avatar blacktop commented on July 18, 2024

fixed in blacktop/go-macho@237bf71

from ipsw.

blacktop avatar blacktop commented on July 18, 2024

FYI @Rokey1990 in the future that was an issue in the go-macho pkg

Thank you for letting me know!

from ipsw.

blacktop avatar blacktop commented on July 18, 2024

@Rokey1990 this should be fixed now

from ipsw.

blacktop avatar blacktop commented on July 18, 2024

wait, there might be something weird going on w/ a collision of go-macho versions?

from ipsw.

blacktop avatar blacktop commented on July 18, 2024

I think I somehow accidentally created a tag for this before and it got registered w/ the Go pkgs

So I just created another go-macho release to avoid this collision as I don't know how to remove the prev cached tag in the golang pkg servers etc

from ipsw.

blacktop avatar blacktop commented on July 18, 2024

Ok @Rokey1990 this should be fixed (for real this time)

from ipsw.

Rokey1990 avatar Rokey1990 commented on July 18, 2024

It does't works well. this is not a category-specific problem, the same problem exists with other symbols, such as classes.

I think the GetBindName also has a bug too, the "categoryPtr.ClsVMAddr" is always 0 for NSObject or UIView(symbols in other dynamic libraries),this case, GetBindName will return NSObject only, even the real class name is UIView.

// GetBindName returns the import name for a given dyld chained pointer
func (f *File) GetBindName(pointer uint64) (string, error)

In some documents, they use the address of categoryPtr.ClsVMAddr(ptr + sizeof(uint64)) to get the bind name, Whether we need to do the same?

my debug image:
image
image

our implement:
image

from ipsw.

blacktop avatar blacktop commented on July 18, 2024

do you have a specific example in the orig binary you supplied for UIView?

I believe I've fixed the ptr==0 case for category class name lookup

I'll now try and fix it everywhere else it is used

from ipsw.

blacktop avatar blacktop commented on July 18, 2024

@Rokey1990 please check latest release

from ipsw.

blacktop avatar blacktop commented on July 18, 2024

I believe I've mostly been testing binaries w/ the NEW chained-fixup binds/rebases so didn't properly test the OLD LC_DYLD_INFO_ONLY style as much w/ Objc

Thank you for reporting!

Please keep these issues coming! and make sure to also test out all the Swift parsers as well 👍

from ipsw.

Rokey1990 avatar Rokey1990 commented on July 18, 2024

@blacktop Thanks! The latest release has been verifield, it works for earlier macho file👍!

But there are still some problems with the fix, as follow:

  • Dump objc root class error, superclass ptr=0, GetBindName are still called?
  • Dump some swift types error while parseGenericContext(go-macho/swift.go), It may be caused by wrong use of GetBindName or getContextDesc?

You can use the latest macho file to reproduce it ReviewToolDemo.zip

The swift parsers i have tested using ealier version, But just some simple usage!I'll go into more detail later,If any problems are found, I will inform you as soon as possible!

And I have some feature suggestions, hope to implemented, Many thanks!

  • class-dump, some objc class name may contains swift demangled string, hope to add a config to demangle it!
  • swift-dump, '-o' option seem to not woking, It's a exciting feature for further parsing!

from ipsw.

blacktop avatar blacktop commented on July 18, 2024

This should now be fixed in master (i'll push out a new release soon, just waiting on #451)

I also added a --demangle flag to the class-dump cmd, but it just does the same thing as using the -V flag (meaning -V already swift-demangles the class-dump)

from ipsw.

Rokey1990 avatar Rokey1990 commented on July 18, 2024

Nothing is wrong with master👍! Thank you!

from ipsw.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.