Dramatic performance difference between blade component and blade helper

[MaxGiting]

Dramatic performance difference between blade component and blade helper

[driesvints]

Hey @MaxGiting, I think you might have missed the caching section here? https://github.com/blade-ui-kit/blade-icons#caching

[MaxGiting]

@driesvints Thanks for the quick reply! I should have mentioned it in the original issue. I have caching turned on and still see the time difference.

[driesvints]

@MaxGiting that's very odd. I'll try out your repo as soon as I find some time.

[MaxGiting]

@driesvints thank you. I have simplified the original issue as caching removed the differences on 1st and subsequent page loads. But yes the difference between blade component and @svg still exists.

[JayBizzle]

Just had a quick look into this.

When using the blade component, most of the time is spent in the following method....
https://github.com/laravel/framework/blob/b9203fca96960ef9cd8860cb4ec99d1279353a8d/src/Illuminate/View/Concerns/ManagesComponents.php#L87-L109

Shared equally between this line...
https://github.com/laravel/framework/blob/b9203fca96960ef9cd8860cb4ec99d1279353a8d/src/Illuminate/View/Concerns/ManagesComponents.php#L97

and. this line....
https://github.com/laravel/framework/blob/b9203fca96960ef9cd8860cb4ec99d1279353a8d/src/Illuminate/View/Concerns/ManagesComponents.php#L104

[driesvints]

I managed to reproduce this with your repo @MaxGiting, thank you. However, I did not figure out the root cause of this even though with @JayBizzle indications.

I have to say, that I find the current differences in speed to not be overly dramatic. I use Blade Icons on several projects, and haven't experienced much slowness after we implemented icon caching. Therefor, I won't be taking any action here right now. However, should anyone find the root cause of this, I'd very much appreciate a PR. Otherwise, if this is really a concern for you, I suggest to use the svg helper or directives for now.

Thanks

[Erulezz]

I experienced the same when using the components. Even with caching, requests where around 130 ms slower with the font awesome icons. Disabled components and switched to the svg helper and the difference was really noticeable.

Am I correct in that when using the svg helper it has no impact on performance? Since blade views are created and cached in production?

Thanks for this package @driesvints 👍

[driesvints]

Am I correct in that when using the svg helper it has no impact on performance? Since blade views are created and cached in production?

Not entirely sure if it's "no impact" but it's far less than components apparently.