Giter Site home page Giter Site logo

API: access secrets directly about frigate HOT 4 CLOSED

jhvst avatar jhvst commented on June 23, 2024 1
API: access secrets directly

from frigate.

Comments (4)

blakeblackshear avatar blakeblackshear commented on June 23, 2024

Thanks for reporting.

Genuinely honest question as we are trying to maintain a good workflow around bug reports. How did you submit this issue without selecting a template?

We have a specific link for bug reports on the new issue page, but this was submitted as a generic issue instead.

Screenshot_20240611-062515.png

from frigate.

jhvst avatar jhvst commented on June 23, 2024

This issue was submitted by going to the code, lining up a piece of code, and then clicking on "submit issue" using the GitHub web UI.

from frigate.

blakeblackshear avatar blakeblackshear commented on June 23, 2024

Thanks.

I'm not very familiar with NixOS. Does it look like the following would work?

    elif os.path.isdir("/run/secrets") and os.path.isfile(
        os.path.join("/run/secrets", JWT_SECRET_ENV_VAR)
    ):

from frigate.

jhvst avatar jhvst commented on June 23, 2024

Personally, I would just try to open the filepath directly and fallthrough if it does not open up. I.e., to me, checking whether the directory exists seems redundant if you are then reading a file within it anyway (in other words, reading a file successfully implies that the directory exists).

Aside of that, yes, that looks good to me! Also, thanks for the swift response.

from frigate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.