Giter Site home page Giter Site logo

Comments (8)

bellini666 avatar bellini666 commented on August 17, 2024 1

Hey @DavidLemayian ,

Yeah, that's a regression from v3. I think I know how to fix that, will try to do that soon! :)

from strawberry-django-plus.

bellini666 avatar bellini666 commented on August 17, 2024 1

That is very useful! Will take a look at that probably tomorrow for a proper fix

from strawberry-django-plus.

bellini666 avatar bellini666 commented on August 17, 2024 1

@DavidLemayian OMG, I tested your example and just noticed the reason it didn't work (and I did not notice that at first =P)

Fields are only inherited from other dataclasses/strawberry types. Meaning your CommonType should either be define like:

@dataclasses.dataclass
class CommonType:
    id: strawberry.ID

Or

@strawberry.type
class CommonType:
    id: strawberry.ID

Testing your example locally I could make the test pass by decorating it with @dataclasses.dataclass

from strawberry-django-plus.

DavidLemayian avatar DavidLemayian commented on August 17, 2024 1

Yup @bellini666 . This works 🤦 ❤️

Wishing you a good week ahead

from strawberry-django-plus.

DavidLemayian avatar DavidLemayian commented on August 17, 2024

Thank you @bellini666 ❤️

from strawberry-django-plus.

bellini666 avatar bellini666 commented on August 17, 2024

@DavidLemayian I just release version 3.0.2 which should fix your issue! Could you comment here if it really fixed or not?

from strawberry-django-plus.

DavidLemayian avatar DavidLemayian commented on August 17, 2024

@bellini666 finally managed to test and unfortunately not working.

Not sure if this is useful too - main...DavidLemayian:strawberry-django-plus:main

from strawberry-django-plus.

DavidLemayian avatar DavidLemayian commented on August 17, 2024

Oh wow! Thank you! Will test this later

from strawberry-django-plus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.