Giter Site home page Giter Site logo

Support SystemJS about ng2-datepicker HOT 11 OPEN

bleenco avatar bleenco commented on July 18, 2024 6
Support SystemJS

from ng2-datepicker.

Comments (11)

connecttheworld avatar connecttheworld commented on July 18, 2024 1

Yes, the fastest and easiest solution is to include the HTML and CSS inline in the component. I looked at the way ng2-bootstrap writes their components and it looks like they are doing the same thing. I will do some research on this if I get time, but for now I have forked and updated my repo to reflect these changes: https://github.com/NightImmunity/ng2-datepicker

I don't want to submit any pull requests since I plan on tweaking this for personal use. I will tag this version as 1.1.1.

from ng2-datepicker.

teacii avatar teacii commented on July 18, 2024

Yes pls. same issue

from ng2-datepicker.

jkuri avatar jkuri commented on July 18, 2024

I believe the fastest solution from my side would be including styles and template inline. But that's not okay because I am using sass in dev...
Can you try searching for that case about SystemJS and Angular templateUrl solution?

from ng2-datepicker.

jasonburrows avatar jasonburrows commented on July 18, 2024

Same issue. Just adding my vote to support SystemJS.

from ng2-datepicker.

ghetolay avatar ghetolay commented on July 18, 2024

This seems related to #66.

from ng2-datepicker.

corner22 avatar corner22 commented on July 18, 2024

Same issue. please fix.

from ng2-datepicker.

lmkerr avatar lmkerr commented on July 18, 2024

ditto

from ng2-datepicker.

ghetolay avatar ghetolay commented on July 18, 2024

Can any of you guys checkout that the new version is compatible with systemJS ?

Readme about this new version can be found here.
There is also an example using this new version and systemJS on plunker here.

from ng2-datepicker.

jkuri avatar jkuri commented on July 18, 2024

great stuff @ghetolay. only one question... why did you use datepicker-ionic name?

from ng2-datepicker.

ghetolay avatar ghetolay commented on July 18, 2024

@jkuri well it's a datepicker and it's using ionic classes and icons. So datepicker-ionic seems to fit perfectly.
I don't think I'll have time for that right now but we may have a datepicker-bootstrap, datepicker-material, datepicker-minimal etc...

At first I thought we could make it a configuration using Input or directive but then I realized we cant configure template nor styles. The only way to do that is by creating new component with different selector.
And I may be wrong but I think each framework have it's own philosophy it's not just about theming so each datepicker may also behave differently.

from ng2-datepicker.

baronbaston avatar baronbaston commented on July 18, 2024

For some reason the moduleId in the component declaration is the string 'module.id' instead of the value module.id. Meaning the the html file is still looked for in the root.

On a sidenote. Why are we ment to declare the datepicker ourself as part of the module we are using it from instead of it being defined in its own module which is imported in the consumer module, which I guess is the 'correct' angular way.

from ng2-datepicker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.