Giter Site home page Giter Site logo

Comments (4)

Cerovec avatar Cerovec commented on May 30, 2024

You are right. We'll fix this ASAP.

Both Obj-C and Swift versions have the same issue.

Thanks!

from blinkid-ios.

Cerovec avatar Cerovec commented on May 30, 2024

Lukas,
just to verify - we would use camera type PPCameraTypeBack in our documentation, because it's a more common use case to scan with back facing camera. Is this OK with you?
Thanks!

from blinkid-ios.

Cerovec avatar Cerovec commented on May 30, 2024

Wiki is updated - https://github.com/BlinkID/blinkid-ios/wiki/Getting-started

Please take a look and close if this solves your issue.

from blinkid-ios.

lukaskukacka avatar lukaskukacka commented on May 30, 2024

@Cerovec Looks fine for me. Thanks. Of course PPCameraTypeBack is correct since it is a default value of settings.cameraSettings, sorry my mistake :-)


Thinking of that, to prevent inconsistency of check vs settings causing potential bugs, I would in my code probably inverse the order like this instead:

PPSettings *settings = [[PPSettings alloc] init];

if ([PPCoordinator isScanningUnsupportedForCameraType:settings.cameraSettings.cameraType error:error]) {
    return nil;
}

This way, the check is always made to settings which which will actually be used.

from blinkid-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.