Giter Site home page Giter Site logo

mint color 0 需要2支 API about oss HOT 1 OPEN

apjiyi avatar apjiyi commented on August 14, 2024
mint color 0 需要2支 API

from oss.

Comments (1)

BenjaminLu avatar BenjaminLu commented on August 14, 2024

OSS利用gcoinrpc內的BitcoinConnection物件做rpc的操作

https://github.com/OpenNetworking/gcoin-rpc/blob/develop/src/gcoinrpc/connection.py#L898

但這個wrapper class沒有做太多事情,就直接轉給AuthServiceProxy物件做事

https://github.com/OpenNetworking/gcoin-rpc/blob/develop/src/gcoinrpc/connection.py#L52

可能當初的想法是想透過這種方式限定rpc可以呼叫的方法

但是這樣就會造成現在的情況,每每core有新增指令,gcoinrpc就要先修改

再來OSS也要作出對應的API修正

這樣對gcoinrpc這個套件來說,其實靈活度也不高

我建議做成一個command方法即可,要限定使用哪些RPC方法可以呼叫,哪些RPC方法不行

這點應該在OSS層限定就好,gcoinrpc應該要能提供一個很靈活的呼叫方法

不會因為core要做更動,就要跟著改動

另外這需求,應該還要新增getmemberlist的API

否則不知道license/prepare時alliance共識的地址

https://github.com/OpenNetworking/OSS/blob/master/oss_server/base/v1/views.py#L75

from oss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.