Giter Site home page Giter Site logo

Comments (9)

TmasLee avatar TmasLee commented on July 28, 2024 5

Hi, I could look into this when I can!

from blockchain-wallet-v4-frontend.

schnogz avatar schnogz commented on July 28, 2024 1

Awesome, thanks so much @sendmebiscuits!

Just comment on the issue with the areas that you're working on so we don't have overlapping work between people. Also, if you have any questions or need help testing, feel free to reach out to me or @plondon anytime!

from blockchain-wallet-v4-frontend.

TmasLee avatar TmasLee commented on July 28, 2024 1

Sure thing! I'll take care of those in a bit.

from blockchain-wallet-v4-frontend.

TmasLee avatar TmasLee commented on July 28, 2024

Quick question before I start touching anything, should code in the deprecated lifecycle methods be refactored based on how the React Docs suggest? Or just a complete deletion of the deprecated method?

from blockchain-wallet-v4-frontend.

plondon avatar plondon commented on July 28, 2024

Let's just start with removing the deprecated methods please

from blockchain-wallet-v4-frontend.

TmasLee avatar TmasLee commented on July 28, 2024

Hey guys, I finally had some time to go through the code. I found and deleted 1 componentWillMount and 1 componentWillReceiveProps in packages/blockchain-info-components/src/Carousels/Carousel/index.js and packages/blockchain-info-components/src/Form/SelectInput/index.js. I'll push the changes and make a pull request.

from blockchain-wallet-v4-frontend.

prwelber avatar prwelber commented on July 28, 2024

Thanks @sendmebiscuits, we appreciate your help πŸ‘

There's a bunch more in packages/blockchain-wallet-v4-frontend/src. Let me know if you want to tackle those as well.

from blockchain-wallet-v4-frontend.

prwelber avatar prwelber commented on July 28, 2024

Work ongoing here: #876

from blockchain-wallet-v4-frontend.

plondon avatar plondon commented on July 28, 2024

Closing!

from blockchain-wallet-v4-frontend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.