Address 404 page

[blockscout]

Address 404 page

[jimmay5469]

I'm updating this as I don't believe a 404 page is the right approach. I believe what we should actually show is a 0 balance Address with no transactions to/from it.

[acravenho]

@jimmay5469 That's correct. A user should see the full page with 0 balances.

I can handle this issue.

Have you guys already started working on it? @acravenho

[acravenho]

@Lokraan No, we haven't started working on this yet. That would be great!

@acravenho

I have a solution that utilizes this function to get addresses:

def find_or_insert_address_from_hash(%Hash{byte_count: unquote(Hash.Address.byte_count())} = hash) do
    case Chain.hash_to_address(hash) do
      {:ok, address} ->
        {:ok, address}

      {:error, :not_found} ->
        Chain.create_address(%{hash: to_string(hash)})

      :error ->
        :error
    end
  end

As a result of this AddressView.contract?/1 throws an error because the created address has this: smart_contract: #Ecto.Association.NotLoaded<association :smart_contract is not loaded>. I am able to solve this by setting smart_contract to :nil in the by passing the value into the changeset, but I was wondering why contract_code gets set to :nil when smart_contract doesn't?

%Explorer.Chain.Address{__meta__: #Ecto.Schema.Metadata<:loaded, "addresses">, contract_code: nil, contracts_creation_internal_transaction: #Ecto.Association.NotLoaded<association :contracts_creation_internal_transaction is not loaded>, fetched_coin_balance: nil, fetched_coin_balance_block_number: nil, hash: %Explorer.Chain.Hash{byte_count: 20, bytes: <<203, 188, 213, 172, 134, 249, 165, 14, 19, 49, 54, 51, 178, 98, 225, 111, 105, 90, 144, 195>>}, inserted_at: #DateTime<2018-10-13 02:14:20.341184Z>, names: #Ecto.Association.NotLoaded<association :names is not loaded>, smart_contract: #Ecto.Association.NotLoaded<association :smart_contract is not loaded>, token: #Ecto.Association.NotLoaded<association :token is not loaded>, updated_at: #DateTime<2018-10-13 02:14:20.341192Z>}