Giter Site home page Giter Site logo

Comments (5)

xynydev avatar xynydev commented on July 17, 2024

If you are doing a PR from your own repository, I guess, since it is intended that both internal branches without PRs and external PRs without internal branches run a build. I guess one of those could be disabled in the action, though.

from template.

plata avatar plata commented on July 17, 2024

If you agree to have the push build only on branch main, I can open a PR for it.

from template.

xynydev avatar xynydev commented on July 17, 2024

No, it is intended that pushes happen on all branches and on PRs. It can be considered a bug or and edge case than on an in-repo PR both builds are triggered, and a PR mitigating that would be merged.

from template.

plata avatar plata commented on July 17, 2024

This doesn't seem to be easy to achieve with the current workflow syntax. This proposal would help.

The only possibility apparently is a conditional implementation per job: https://github.com/orgs/community/discussions/57827.

However, if the build runs for every push anyway, why would you even want to have the pull_request trigger as well? Is there any possibility to create a pull request change without a push?

from template.

xynydev avatar xynydev commented on July 17, 2024

However, if the build runs for every push anyway, why would you even want to have the pull_request trigger as well? Is there any possibility to create a pull request change without a push?

Yes, it is. push only runs if the push is into the repository, while pull_request also triggers on PRs from forks.

The only possibility apparently is a conditional implementation per job: https://github.com/orgs/community/discussions/57827.

That is not only the only possibility, but the best one. The action in this repository only has a single job with a single step, so no repetition would be needed.

from template.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.