Protobuf messages registration conflicts

[bnb-chain]

Protobuf messages registration conflicts

[PlamenHristov]

Hey @omershlo,

We've noticed that when both ecdsa and eddsa are used depending on the intialization order, protobuf can't handle both at runtime because of name clashes.

I've opened a PR to fix that. As a side effect the warnings have been cleared as well.

Let me know what you think.

[omershlo]

hi @lukasz-zimnoch , thank you for reporting,
can you suggest ways to fix this issue?

[Shadowfiend]

Thoughts on fixing this by simply removed from messages.go? If the generated pb.go file takes care of registration, the explicit manual registration in messages.go seems like it should be unnecessary. The init function is used in both cases, and both thepb.go file and messages.go are in the same package which means both registrations run at the same time during package initialization. That should mean the messages.go init function is redundant. I believe this should be true even on earlier versions that may not warn on duplicate registration.

[yycen]

This PR also fixed the issue.
See go.mod
ecdsa/signing/messages.go
ecdsa/keygen/ecdsa-keygen.pb.go
and other related part.