Wrong make on FreeBSD

[bnoordhuis]

Wrong make on FreeBSD

[bnoordhuis]

Not sure what your question is, can you elaborate? The only thing you should need to do on freebsd is to run gmake instead of make.

[Artazor]

I mean that on FreeBSD you can't install node-iconv using npm as easy as it could be.

Using npm install iconv after several succesful steps produces an error:

Waf: Entering directory `/usr/home/user/sample/node_modules/iconv/build'
"Makefile", line 3: Missing dependency operator
"Makefile", line 5: Need an operator
"Makefile", line 7: Missing dependency operator
"Makefile", line 8: warning: duplicate script for target "ifeq" ignored
"Makefile", line 9: Need an operator
"Makefile", line 27: Missing dependency operator
"Makefile", line 28: warning: duplicate script for target "ifeq" ignored
"Makefile", line 29: Need an operator
"Makefile", line 31: Need an operator
make: fatal errors encountered -- cannot continue

(it means that wrong make is being used)

It would be nice to install node-iconv through npm install on FreeBSD as well :]

[bnoordhuis]

Right, I see what you mean. Does commit 7577828 work for you?

[Artazor]

Yes, now it chooses right make/gmake, but there is still an error, since CPPPATH_NODE is not a string, but a list (at least, in my case)

g++ -Ideps/libiconv/include -Ideps/libiconv/lib -I['/usr/local/include/node', '/usr/local/include'] -D_FORTIFY_SOURCE=2 -DEV_MULTIPLICITY=0 -fPIC -Wall -Wextra -ansi -O2 -c -o iconv.o iconv.cc
g++: /usr/local/include]: No such file or directory

[bnoordhuis]

WAF at its finest... can you try 87ebcdc?

[Artazor]

Yep! Now it works!

[bnoordhuis]

Fixed in v1.1.3.

[curana]

Seems this problem came back in current 1.2.1

[bnoordhuis]

It's a bug in node-gyp. See nodejs/node-gyp#66 for details.