`strtod` might be unsafe on some systems

[boazsegev]

`strtod` might be unsafe on some systems

[frink]

Could we copy an existing implementation from one of the many libs around?
Or would it be better to simplify for our single use case?

[boazsegev]

@frink ,

You're probably right. Finding a good implementation with an MIT license and integrating it is would probably be the most effective approach - especially if we could use the makefile script to install it directly from the original repo.

However, there's a couple of reasons I'm holding off on that:

1. I want to support binary representation, (0b01...), parsing doubles using their binary IEEE 754 representation. The fio_atol adds support for binary numbers and I thought fio_atof should follow suite.

2. I love to understand the code that I use, just so I can better maintain the project. That's why I prefer (when possible) to give it a try myself and solve what I can before integrating someone else's code / approach.

Having said that, adding a task to the makefile, like the one for BearSSL, would be a great solution.

[frink]

Musl is MIT. Don't know if it supports binary representations or not...

This one is public domain but may need a little finesse:
https://gist.github.com/mattn/1890186

[boazsegev]

Thanks for taking the time to find a solution.

Lets put this one on low priority, there's a bunch of stuff that uses strtod and not all systems have issues in their implementations.

I think BearSSL would be more important than this side-detail.

Also...

Musl (edit: the public domain version in the link) suffers from more rounding errors my current version suffers from (my current, un-uploaded version, has 52bit precision on the mantissa instead of 53 bit precision, which is my only issue).

In addition, Musl (edit: the public domain version in the link) doesn't support hex notation, NaN and Infinity... which I think could be important (my version also supports binary notation, but I didn't finish the hex notation yet).

[boazsegev]

Correction: I was looking at the public domain implementation. The Musl library might be a good option for an strtod patch. I'll review it later.

[frink]

Good dea!