Giter Site home page Giter Site logo

Comments (17)

BobbyWibowo avatar BobbyWibowo commented on July 26, 2024 1

You may want to consider starting lolisafe with SERVE_STATIC_QUICK=0 environment variable as well, to disable the implementation of establishing Readable stream for static assets of the front-end pages (JS/CSS files, logos, etc. - lolisafe will then instead pre-cache the files into memory)

It didn't seem like any front-end assets went wrong on your end, despite the implementation being identical with how it serves uploaded files

But you should probably do it anyways just in case


Do please let me know if you find out anything else of interest

Just leave this issue open

from lolisafe.

samstarnes avatar samstarnes commented on July 26, 2024 1

Hello @flleeppyy, it's me, the owner of 0x0. I have noticed this on my end. I'll be honest, I haven't updated my safe in quite some time but I'll be sure to try to upgrade soon and see if this fixes the problem. Currently on git commit 08db3e5 so it's rather old.

To replicate this I've noticed if I attempt to download a file and close the tab quickly but upon reopening the tab the download begins. Same error with "0 bytes/sec." Not sure what's causing it but haven't looked further into it. As for you, @BobbyWibowo, I'll try to pinpoint what's the deal is as well when I have the time.

from lolisafe.

flleeppyy avatar flleeppyy commented on July 26, 2024 1

Yeah I am using cloudflare, but again it still happens without it, such as directly accessing it on the server via local host, or directly via ip

from lolisafe.

BobbyWibowo avatar BobbyWibowo commented on July 26, 2024

Are you currently serving files with node? (i.e. serveFilesWithNode: true in config)

from lolisafe.

flleeppyy avatar flleeppyy commented on July 26, 2024

Yes

from lolisafe.

BobbyWibowo avatar BobbyWibowo commented on July 26, 2024

I have a linode server in Dallas, TX on their base tier (1GB Ram, 20gb storage), and some additional storage (80gb).

Is that additional storage some type of network storage? Only relevant if you configure your safe to store the uploaded files into it however

from lolisafe.

flleeppyy avatar flleeppyy commented on July 26, 2024

Nope. Everything is stored on the windows server (The windows server is just a computer that sits in my closet).

from lolisafe.

flleeppyy avatar flleeppyy commented on July 26, 2024

Files on the server seem to be intact, (Windows server on left, local copy of what i uploaded on the right)
image

from lolisafe.

flleeppyy avatar flleeppyy commented on July 26, 2024

The linode server is only used for reverse proxying safe.fleepy.tv, to my windows server on the vpn

from lolisafe.

flleeppyy avatar flleeppyy commented on July 26, 2024

I gotta head to bed, will respond later on this topic c:

from lolisafe.

BobbyWibowo avatar BobbyWibowo commented on July 26, 2024

The only likely point of suspicion is the fact that if you serve uploaded files with node, the safe will establish a Readable stream to the physical file upon download

And it sounds like something in your setup is causing that to hiccup, somehow

Unfortunately, issue relating to this specific part of the code is very hard to debug, so I can't really say why it behaves that way on your end

You should probably consider serving uploaded files directly with Nginx or the likes instead

from lolisafe.

flleeppyy avatar flleeppyy commented on July 26, 2024

I'm not sure what options are available to me...

from lolisafe.

flleeppyy avatar flleeppyy commented on July 26, 2024

Well, it's something with lolisafe since I get the same issue when fetching the file from the server locally.

from lolisafe.

BobbyWibowo avatar BobbyWibowo commented on July 26, 2024

The only likely point of suspicion is the fact that if you serve uploaded files with node, the safe will establish a Readable stream to the physical file upon download

And it sounds like something in your setup is causing that to hiccup, somehow

I wasn't pointing at your network setup by this, but the actual machine itself, as in how Node.js interacts with your physical disk

It doesn't surprise me that it behaves the same when fetching the files locally

from lolisafe.

flleeppyy avatar flleeppyy commented on July 26, 2024

Alright well I figured out how IIS works, and now it's serving through https://safe.fleepy.tv/files

It seems to work fine for now.

from lolisafe.

flleeppyy avatar flleeppyy commented on July 26, 2024

Later in the future I want to figure out why its serving like that incorrectly

from lolisafe.

samstarnes avatar samstarnes commented on July 26, 2024

Updated from 08db3e5 to 7f7f218.

The issue still exists under 7f7f218 if you save a file (something large to recreate this bug) then close the tab immediately. I chose something not too big but something I could download slow enough to quickly close the tab. Still got 0 bytes/sec but then eventually the file did download. I also re-encoded the video with the -movflags +faststart flags as well to place the MOOV atom file to the front of the video to see if that helped as well. Using Firefox 103.0.2 and tried Chrome 104.0.5112.102. This only happened in Firefox. In Chrome, the file downloaded file but gave no estimated time. The video continued to download and the size only increased as it continued to download more chunks.

I'm not sure if you're using CloudFlare,, @flleeppyy, but since I am the files are being transferred using chunked transfer encoding so the size can't be determined and a time can't be estimated. It finishes when it receives a terminating chunk message.

Now why this happens when you click the link, leave it open and it still chooses to stay at 0 bytes/sec in Firefox? Dunno. The only way to start the download seemed to be either a) reopen the link or b) skip through the video so it's past the point that's been loaded. Obviously won't work with things like archives other than reopening the links. This does not happen in Chrome at all so this appears to be a Firefox issue with chunked files.

from lolisafe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.