detach() with no parameter doesn't work

[bookshelf]

detach() with no parameter doesn't work

[tgriesser]

Thanks for that @chymz - I fixed it slightly differently, but I also made the fulfilled promise value of the attach/detach to be the belongsToMany collection object currently being used. Should be fixed in 0.1.7.

[teckays]

More than 2 years and it still does't work!!!!

[johanneslumpe]

@teckays instead of being hostile, how about pulling yourself together and creating a fix for it?

[melardev]

Hi, this feature still has a bug, detach only works if there is something to delete, if there is no rows to delete then it triggers an exception. I have tested with detach() and detach([]), they both trigger an exception with the following stacktrace:

CustomError: EmptyResponse
    at Child.<anonymous> (D:\MyBookshelfProject\node_modules\bookshelf\lib\model.js:715:21)
    at PassThroughHandlerContext.finallyHandler (D:\MyBookshelfProject\node_modules\bluebird\js\release\finally.js:57:23)
    at PassThroughHandlerContext.tryCatcher (D:\MyBookshelfProject\node_modules\bluebird\js\release\util.js:16:23)
    at Promise._settlePromiseFromHandler (D:\MyBookshelfProject\node_modules\bluebird\js\release\promise.js:512:31)
    at Promise._settlePromise (D:\MyBookshelfProject\node_modules\bluebird\js\release\promise.js:569:18)
    at Promise._settlePromise0 (D:\MyBookshelfProject\node_modules\bluebird\js\release\promise.js:614:10)
    at Promise._settlePromises (D:\MyBookshelfProject\node_modules\bluebird\js\release\promise.js:694:18)
    at _drainQueueStep (D:\MyBookshelfProject\node_modules\bluebird\js\release\async.js:138:12)
    at _drainQueue (D:\MyBookshelfProject\node_modules\bluebird\js\release\async.js:131:9)
    at Async._drainQueues (D:\MyBookshelfProject\node_modules\bluebird\js\release\async.js:147:5)
    at Immediate.Async.drainQueues [as _onImmediate] (D:\MyBookshelfProject\node_modules\bluebird\js\release\async.js:17:14)
    at runCallback (timers.js:705:18)
    at tryOnImmediate (timers.js:676:5)
    at processImmediate (timers.js:658:5)