`format` should be called for `select`, `delete`, and `first` queries

[bookshelf]

`format` should be called for `select`, `delete`, and `first` queries

[tgriesser]

First makes sense, since that's based off the model attr's... what would the format be used on with the select and delete query though?

[vjpr]

@forge
      name: profile.displayName
      fb: JSON.stringify profile
      fbId: profile.id
.save() ...

@forge({fbId: profile.id}).fetch() // runs `where fbId = $1` instead of `where fb_id = $1`

Delete would be the same if using something other than id.

[tgriesser]

Currently delete only uses the id, unless you add where clauses to the query like so:

model.query('where', 'fb_id', 'username').delete()

But I could probably change it so that if you tried to delete a model and didn't have an idAttribute it used the other attrs in the object to delete... would that make sense?

[vjpr]

Probably quite a rare case but sounds good.

Just clarifying from my last post, the main issue is select queries not running format when using fetch.

@forge({fbId: profile.id}).fetch() // runs where fbId = $1instead ofwhere fb_id = $1``

This complicates things like findOrCreate.

[tgriesser]

Right... I'll change it to use format in the first fetch call for models.

[vjpr]

First makes sense, since that's based off the model attr's...

...just realised what you meant - I didn't read that as the method Sync#first.

Makes sense now.

[tgriesser]

Decided not to make the change on the delete... The reasoning that it shouldn't be easy to delete models if you accidentally left of the idAttribute value or something... for this you'll need to do

model.query('where', {some: 'value'}).del(...`

The Sync#first should be good now.