External Link Modal confirmation window

[xmgz]

External Link Modal confirmation window

[timothyjrogers]

This issue is caused by the template code in the verification modal here: https://github.com/bookwyrm-social/bookwyrm/blob/main/bookwyrm/templates/book/file_links/verification_modal.html#L20-L27

All three buttons ("Report Spam", "Cancel", and "Continue") are all wrapped in the authentication check which renders zero options when you are logged out. I assume this was added to prevent abuse of the spam reporting feature by unauthenticated users/bots, but leaving an essentially dead modal seems unintentional.

It's trivial to fix, I'll submit a PR reducing the authentication check to the "Report Spam" link. If a more knowledgeable maintainer can explain why the other two buttons would need an authentication check we can explore a more detailed fix.

[timothyjrogers]

I'm able to reproduce this on books.infosec.exchange which (at time of writing) is on Bookwyrm version 0.7.3 as well as in my developer environment on current main code.

The behavior appears correct when logged in -- the modal provides me the option to continue to the link or back out -- however when not logged in I get the do-nothing modal you describe.

When logged in:

When logged out: