Comments (2)
This issue is caused by the template code in the verification modal here: https://github.com/bookwyrm-social/bookwyrm/blob/main/bookwyrm/templates/book/file_links/verification_modal.html#L20-L27
All three buttons ("Report Spam", "Cancel", and "Continue") are all wrapped in the authentication check which renders zero options when you are logged out. I assume this was added to prevent abuse of the spam reporting feature by unauthenticated users/bots, but leaving an essentially dead modal seems unintentional.
It's trivial to fix, I'll submit a PR reducing the authentication check to the "Report Spam" link. If a more knowledgeable maintainer can explain why the other two buttons would need an authentication check we can explore a more detailed fix.
from bookwyrm.
I'm able to reproduce this on books.infosec.exchange which (at time of writing) is on Bookwyrm version 0.7.3
as well as in my developer environment on current main
code.
The behavior appears correct when logged in -- the modal provides me the option to continue to the link or back out -- however when not logged in I get the do-nothing modal you describe.
When logged in:
When logged out:
from bookwyrm.
Related Issues (20)
- Account import fails with error: 'attributedTo' HOT 3
- Wrong CSS paths with S3 object storage (while non-CSS assets paths are correct) HOT 7
- Switch to an OSI-approved license HOT 2
- "Most Loved" Doesn't Dedupe by User
- Send e-mail on group invitation
- Trim leading and trailing spaces in search HOT 1
- Clarification about nginx configuration introduced at 0.7.2 HOT 7
- ModuleNotFoundError: No module named 'oauth2_provider' HOT 4
- Dates wrong when importing from storygraph
- Feature Request: Show Ratings/Reviews completed in left-side book carousel
- Start date blank when finishing a book HOT 2
- Missing characters from book preview image font HOT 2
- Federation doesn't seem to work for books and reviews HOT 1
- Federation with NeoDB
- Not a bug but problem for me HOT 3
- Error DuplicateTable on ./bw-dev migrate command HOT 1
- Show reviews body text on other fediverse networks HOT 2
- External Blocklists HOT 1
- Book editions can't be deleted / edited HOT 1
- Canβt search for or mention an octodon.social account HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bookwyrm.