Giter Site home page Giter Site logo

Comments (16)

anadon avatar anadon commented on July 21, 2024 1

Just an update, had to move twice, once across states, and started a new job. Getting back to this more now.

from graph.

jeremy-murphy avatar jeremy-murphy commented on July 21, 2024 1

Not sure if they are still active on Boost.Graph, but if someone submits a pull request to fix this issue, I can help them get it polished and merge it.

from graph.

anadon avatar anadon commented on July 21, 2024

@jzmaddock Hey, this looks like a good one for me to work on.

from graph.

jzmaddock avatar jzmaddock commented on July 21, 2024

Go for it!

from graph.

anadon avatar anadon commented on July 21, 2024

@arneboe Can I get your full name and email, since what you submitted is what I'm basing the regression test on? I need to credit you.

from graph.

arneboe avatar arneboe commented on July 21, 2024

I dont care about the credit, but if you have to: Arne Böckmann

from graph.

anadon avatar anadon commented on July 21, 2024

It looks like the intended design, given the state of BGL, is to have _map a protected member, not a private member. So you hack was less of a hack than was expected.

from graph.

anadon avatar anadon commented on July 21, 2024

This may take longer than expected: https://github.com/boostorg/graph/blob/develop/include/boost/graph/adjacency_matrix.hpp#L992

from graph.

anadon avatar anadon commented on July 21, 2024

May be related: https://svn.boost.org/trac10/ticket/7863

from graph.

anadon avatar anadon commented on July 21, 2024

This is going to be delayed somewhat. There are general cleanups in testing which I need to do first.

from graph.

HWiese1980 avatar HWiese1980 commented on July 21, 2024

Sure, take your time! Better have it fixed correctly and thoroughly, than to rush it and only come up with some quick'n'dirty patch that fails somewhere else.

from graph.

HWiese1980 avatar HWiese1980 commented on July 21, 2024

Alright, no pressure. Just don't forget it ;-)

from graph.

fjch1997 avatar fjch1997 commented on July 21, 2024

And... it was forgotten
This bug really tripped me up when I tried to use labeled_graph

from graph.

HWiese1980 avatar HWiese1980 commented on July 21, 2024

As it seems... @anadon how's it going?

from graph.

EduardoGoulart1 avatar EduardoGoulart1 commented on July 21, 2024

Hey there, any update on it? @anadon by any chance do you still have your WIP PR that people can pick up from?

from graph.

DeuceBox avatar DeuceBox commented on July 21, 2024

This may be related:

There was a patch at https://svn.boost.org/trac/boost/ticket/9493 (I did not create it) which is no longer reachable, but I've been using it in production for years

I've preserved it here:
DeuceBox@de651cb

It appears to fix the bug in the minimal example given in the OP.

from graph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.