Optional bench and build time cloning of nlohmann and rapidjson

[boostorg]

Optional bench and build time cloning of nlohmann and rapidjson

[ayounes-synaptics]

Thanks.
As a side note, just for information, I think a lot of people like the fact that this library can be used in standalone, independently from boost. Also Modularized boost is actually using git submodule and I guess it will use this git?

[vinniefalco]

I will look into it but remember that this is going to be proposed for Boost, and you will get the library through Boost, not through git. In that configuration there will be no submodule or benchmark program.

[vinniefalco]

Modularized boost is actually using git submodule and I guess it will use this git?

Ah, so some other project is doing a deep fetch of the submodules in my json lib?

[ayounes-synaptics]

Modularized boost is actually using git submodule and I guess it will use this git?

Ah, so some other project is doing a deep fetch of the submodules in my json lib?

Exactly yes.

[vinniefalco]

Maybe I can just put a bash script there instead which clones the necessary repositories and specific commit ids, and remove the submodules.

[ayounes-synaptics]

Maybe I can just put a bash script there instead which clones the necessary repositories and specific commit ids, and remove the submodules.

That would also work indeed. But ExternalProject_Add() will do that for you and even call cmake automatically at build time on the child project (if using cmake).

[vinniefalco]

Oh... :) That looks very nice, I will try that.

[vinniefalco]

We went the bash script route, which places less burden on the CML file.