Giter Site home page Giter Site logo

Comments (2)

pdimov avatar pdimov commented on May 30, 2024

https://godbolt.org/z/5Pdd7nvbz doesn't work, one needs to do https://godbolt.org/z/8YocbodaG.

The workaround is to use auto&&, but it would be more consistent for auto& to work, as nullptr is the only case that passes an rvalue.

from json.

grisumbras avatar grisumbras commented on May 30, 2024

I've written a fix, but then decided to also write a rvalue reference overload for visit, at which point I've reached a conundrum. We don't have rvalue ref-qualified overloads for e.g. get_bool and get_double, as there's no need for them. Due to that a visitor that has a bunch of operator(T&&) overloads will not work. Which makes me rethink whether it's actually necessary to make visitor::operator()(nullptr_t&) work. Maybe it is better to simply better explain the behaviour in documentation.

On the other hand, a visitor with operator(T) overloads will work with rvalue ref-qualified overload, so maybe that's good enough?

from json.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.