Comments (10)
from spirit.
When you say supposed to fail, do you mean that they should always fail, or that they are known to fail on these compilers?
from spirit.
Looking at http://www.boost.org/development/tests/develop/developer/spirit.html, these tests do indeed fail across the board; but looking at the tests themselves, they don't seem like they are supposed to fail.
from spirit.
When you say supposed to fail, do you mean that they should always fail, or that they are known to fail on these compilers?
These tests have to fail compilation in order to pass the test.
Looking at http://www.boost.org/development/tests/develop/developer/spirit.html, these tests do indeed fail across the board; but looking at the tests themselves, they don't seem like they are supposed to fail.
The name indicates this (grammar_fail
, rule_fail
).
from spirit.
I see no grammar_fail
or rule_fail
anywhere in
https://github.com/boostorg/spirit/blob/develop/test/karma/alternative1.cpp
and
https://github.com/boostorg/spirit/blob/develop/test/karma/alternative2.cpp
from spirit.
@pdimov is right about the fails. Karma alternative is partly broken for about a year, the new boost:optional
implementation had opened a can of worms. You can workaround this with BOOST_OPTIONAL_CONFIG_USE_OLD_IMPLEMENTATION_OF_OPTIONAL
. I am currently investigating the issue.
testing.capture-output bin.v2/libs/spirit/test/karma_alternative1-p3.test/gcc-gnu-4.8/debug/cxxstd-11/threadapi-pthread/karma_alternative1-p3.run
====== BEGIN OUTPUT ======
in test: result is false
in test: result is false
in test: result is false
libs/spirit/test/karma/alternative1.cpp(67): test 'test("10", char_ | int_, v)' failed in function 'int main()'
in test: result is false
libs/spirit/test/karma/alternative1.cpp(68): test 'test("10", int_ | char_, v)' failed in function 'int main()'
in test: generated "a"
libs/spirit/test/karma/alternative1.cpp(71): test 'test("10", int_ | lit('a') | char_, v)' failed in function 'int main()'
in test: result is false
libs/spirit/test/karma/alternative1.cpp(74): test 'test("c", char_ | int_, v)' failed in function 'int main()'
in test: generated "a"
libs/spirit/test/karma/alternative1.cpp(76): test 'test("c", char_ | lit('a') | int_, v)' failed in function 'int main()'
in test: generated "a"
libs/spirit/test/karma/alternative1.cpp(78): test 'test("c", int_ | char_ | lit('a'), v)' failed in function 'int main()'
in test: result is false
6 errors detected.
EXIT STATUS: 1
====== END OUTPUT ======
testing.capture-output bin.v2/libs/spirit/test/karma_alternative2-p3.test/gcc-gnu-4.8/debug/cxxstd-11/threadapi-pthread/karma_alternative2-p3.run
====== BEGIN OUTPUT ======
in test: result is false
in test: result is false
in test: result is false
in test: result is false
in test_delimited: result is false
in test_delimited: result is false
in test_delimited: generated "11 "
libs/spirit/test/karma/alternative2.cpp(119): test 'test_delimited("10.0 ", double_ | lit(11), v, char_(' '))' failed in function 'int main()'
in test_delimited: result is false
in test_delimited: result is false
1 error detected.
EXIT STATUS: 1
====== END OUTPUT ======
from spirit.
@Kojoley thanks a lot! Your help is very much appreciated!
from spirit.
I confirm that Travis is happy with this change: https://travis-ci.org/boostorg/boost/builds/301455130
from spirit.
Appveyor also fine: https://ci.appveyor.com/project/boostorg/boost/build/1.0.4754-develop
Except for msvc-12.0 errors caused by boostorg/fusion#159
from spirit.
I believe boostorg/fusion#161 fixes the error.
from spirit.
Related Issues (20)
- Spirit Classic Codegen Bug with GCC in Release Builds HOT 3
- provide example for the on_success() handler HOT 4
- iso8859_1::isgraph doesn't work correctly
- x3::unicode::format does not recognize certain format control characters HOT 3
- apparent uselessness of as_spirit_parser(...)? HOT 6
- no_case is a type in some make_primitives specializations, and a bool in others. HOT 1
- Boost Spirit X3 Parser recursive HOT 13
- compile error when using error_handler together with x3::variant
- boost::get overloads for boost::spirit::x3::variant should at least lack BOOST_NOEXCEPT
- x3::variant's converting constructor is explicit HOT 1
- `{qi,karma}::symbols` copy constructor does not make an independent copy HOT 2
- x3::double_ failed to parse 1.D-3 HOT 5
- X3 docs for operators is missing syntactical expressions HOT 1
- X3: Incorrect attribute propagation for alternatives with equal attributes HOT 2
- x3::phrase_parse is not expected
- X3: Vector of variant breaks string attributes if variant also contains character type
- X3: expectation operator ">" with semantic rule "[]" expectation_failure<> uses managled name
- mmap_file_iterator uses too restrictive sharing mode in a call to CreateFileA
- Build error C2061: syntax error: identifier 'BOOST_SCOPED_ENUM' on Windows MSVC HOT 1
- need for "RHS" transform_attribute
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spirit.