boot -d should modify environment

[boot-clj]

boot -d should modify environment

[alandipert]

This turned out not to be a bug - a set-env! call in the build.boot was overwriting :dependencies added at the command line. The fix was to add more dependencies by passing a function to set-env!, like this:

(set-env! :dependencies #(into % '[[foo "1.0.0"] [bar/baz "2.0.0-SNAPSHOT"]]))

[martinklepsch]

@micha @alandipert As I mentioned this seems like an inconsistency. Maybe it's worth printing a note like

You are using -d and have a build.boot file. This can lead to inconsistencies between (get-env :dependencies) and what's actually on the classpath.

I understand that -d is mostly meant for when you don't have a build.boot file but that won't prevent people from using it being unaware of the exact effects this has.

[alandipert]

Hm, I like the idea of printing a note, but I think maybe it would be best to do so only in the exact circumstance you experienced. I know Micha said -d and build.boot shouldn't really mix, but I think it's really -d and build.boot + set-env! :dependencies that don't mix. I can imagine having a build.boot full of task-options and wanting to use -d with it, for instance.

In an effort to be as precise as possible, how about: if you use -d, and later you call set-env! :dependencies <non-function> in your build.boot or in the REPL, (thereby dissociating the dependencies you brought in from the env atom) then we print a message?

I guess this in turn begs the question - should we warn people when any set-env! :dependencies call beyond their first isn't a function? Should this even work?

[martinklepsch]

Right. Showing this only when relevant is the best solution if it's possible without cluttering things.

I guess this in turn begs the question - should we warn people when any set-env! :dependencies call beyond their first isn't a function?

Actually a good idea I think.

Should this even work?

I don't see a use case for it but that doesn't mean there is none. I think I saw @micha mentioning that this can be handy, just don't remember the scenario.