Install Remarkable VNC files if not present

[bordaigorl]

Install Remarkable VNC files if not present

[bordaigorl]

Thanks for testing and for the feedback!
As soon as I have the time to document this a bit I'll merge it.
I think for the moment submodules would be an overkill, I'm not expecting these binaries to be updated often if at all...but thanks for the idea, I'll keep it in mind if things change (for example if RM2 support happens).

[ChrisPattison]

It's worth mentioning that both of these files sum to 350KiB which is quite small

[bordaigorl]

Yes I considered this but I thought it is not nice to upload binaries to the tablet and execute them without the user's explicit consent.
What I would consider is to include a button in the UI to explicitly request the transfer.

[ChrisPattison]

I'm a bit partial to a terminal interface but otherwise I generally agree about uploading/running binaries

[ChrisPattison]

I have in mind to start on a PR for this (like rmview_install ) at some point, but there is a dependency on PR #11

[ChrisPattison]

As a heads up, I am working on this (WIP!) at https://github.com/ChrisPattison/rmview/tree/install
I think there's some work to be done if we want something explicit like a UI button. My plan is to wire this into a config option 'auto_install' that defaults to false.

Separately, currently, there is no checksum or check of /proc/cpuid when the kernel module is loaded. It seems like we might want to

[bordaigorl]

Nice! Thanks.
Ideally one would start the program and be presented with a messagebox if the binaries are missing, with a button offering to install them automatically.
I can quickly add the UI if the logic is in place.
[I guess the best solution would be to have a proper settings dialog...]

[ChrisPattison]

Nice! Thanks.
Ideally one would start the program and be presented with a messagebox if the binaries are missing, with a button offering to install them automatically.
I can quickly add the UI if the logic is in place.
[I guess the best solution would be to have a proper settings dialog...]

This sounds great. The logic is there although it might be a bit troublesome to plumb in

[bordaigorl]

@ChrisPattison I added a branch with an alternative solution.
I included the binaries with the program resources so that installing does not need internet and we control the version and availability of the binaries.
Could you test it?

[ChrisPattison]

I've tested it on my end and it's all good. I think it's a great solution. One thing I would suggest is that the binaries go in a git submodule so that the repository isn't tracking diffs of binaries