Observable change error, when loading jquery.observable.js before jsrender.js, and using contextual parameters and sorted {{for}}

[johan-ohrn]

Observable change error, when loading jquery.observable.js before jsrender.js, and using contextual parameters and sorted {{for}}

[BorisMoore]

Thanks, Johann. Another good find. That is a bug which arises in the case of having jquery.observable.js and jsrender.js and jquery,views.js as separate files, with jquery.observable.js loaded before jsrender.js. I have repro.

I believe that if you load jsrender.js first or use jsviews.js (single file) the issue will not occur.

I'll work to get a fix, then let you know here...

[johan-ohrn]

Great! Once I have this fixed I can push the new version into production.

[BorisMoore]

Hi Johan, I think this should fix the issue:

jsviews2.zip

Let me know if it works for you.

(It also includes a fix to jsrender-node.js, and your issue #447 (comment))

[johan-ohrn]

An other related potential? issue is the following. In jquery.views.js on line 3184:

contextOb = contextOb && $sub.tmplFn(delimOpenChar1 + ":" + contextOb[1] + delimCloseChar0, view.tmpl, true)(linkCtx.data, view);

The compiled function returned by tmplFn() have both j and u input parameters but the call only passes in data and the view. There are a number of places where a similar call is made without passing in the extra parameters. I can't actually remember if I had an issue with it or not.
Just letting you know for your consideration.

[BorisMoore]

You are right!! Thanks...

It is difficult to make a bug scenario that encounters that as an issue, but I managed to do so with this:

{^{on ~util[0].swap ...}}

which I will add to the unit tests.

So I have fixed it in the update below, to pass in $sub:

contextOb = contextOb && $sub.tmplFn(delimOpenChar1 + ":" + contextOb[1] + delimCloseChar0, view.tmpl, true)(linkCtx.data, view, $sub);

The u parameter is intended to be undefined, but in this update I have eliminated the ,u from the generated functions. I previously intended to use u for undefined in generated code, but I don't seem to be leveraging that any more, so I think it is OK to remove it.

Here is the update:

jsviews3.zip

[BorisMoore]

This has been fixed in new release v1.0.7